gm/strokes.cpp - Issue 1813123003: Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.or…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/strokes.cpp

Issue 1813123003: Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.or… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: move flag into sktypes, so it is visible to both paint and other patheffect clients Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/strokes.cpp

diff --git a/gm/strokes.cpp b/gm/strokes.cpp

index 261db9c69d8cb3c245a8df93875b41fde0a8f629..f64a87640c4d41531ec21de59b00bebcc36f72c1 100644

--- a/gm/strokes.cpp

+++ b/gm/strokes.cpp

@@ -128,7 +128,7 @@ protected:

canvas->drawPath(fMoveZfPath, strokePaint);

dashPaint = strokePaint;

const SkScalar intervals[] = { 0, 10 };

- dashPaint.setPathEffect(SkDashPathEffect::Create(intervals, 2, 0))->unref();

+ dashPaint.setPathEffect(SkDashPathEffect::Make(intervals, 2, 0));

SkPath fillPath;

dashPaint.getFillPath(fDashedfPath, &fillPath);

canvas->translate(0, 20);

« no previous file with comments | « gm/patheffects.cpp ('k') | gm/stroketext.cpp » ('j') | no next file with comments »