samplecode/SamplePath.cpp - Issue 1813123003: Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.or…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SamplePath.cpp

Issue 1813123003: Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.or… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: move flag into sktypes, so it is visible to both paint and other patheffect clients Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samplecode/SamplePath.cpp

diff --git a/samplecode/SamplePath.cpp b/samplecode/SamplePath.cpp

index c977ca0dc2a0656a7e25eb5aeebe492c4f72192d..9ef1c851d8d17bf4cbdc2260d2938c566889ea5c 100644

--- a/samplecode/SamplePath.cpp

+++ b/samplecode/SamplePath.cpp

@@ -254,13 +254,13 @@ public:

fArcToPaint.setStyle(SkPaint::kStroke_Style);

fArcToPaint.setStrokeWidth(9);

fArcToPaint.setColor(0x800000FF);

- fArcToPaint.setPathEffect(SkArcToPathEffect::Create(rad))->unref();

+ fArcToPaint.setPathEffect(SkArcToPathEffect::Make(rad));

fCornerPaint.setAntiAlias(true);

fCornerPaint.setStyle(SkPaint::kStroke_Style);

fCornerPaint.setStrokeWidth(13);

fCornerPaint.setColor(SK_ColorGREEN);

- fCornerPaint.setPathEffect(SkCornerPathEffect::Create(rad*2))->unref();

+ fCornerPaint.setPathEffect(SkCornerPathEffect::Make(rad*2));

fSkeletonPaint.setAntiAlias(true);

fSkeletonPaint.setStyle(SkPaint::kStroke_Style);

« no previous file with comments | « samplecode/SampleFilterFuzz.cpp ('k') | samplecode/SamplePathEffects.cpp » ('j') | no next file with comments »