Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1812733004: Store recording invalidations in DisplayListRecordingSource, save them via Update. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Store recording invalidations in DisplayListRecordingSource, save them via Update. This fixes the referenced bug, as well as cleaning up the interaction between PictureLayer and DisplayListRecordingSource a little bit. This way both the invalidation and picture come from DisplayListRecordingSource, rather than one coming from PictureLayer and the other from DisplayListRecordingSource, with the latter modifying the invalidation during Update. Also renamed LayerImpl::GetInvalidationRegion() to LayerImpl::GetInvalidationRegionForDebugging() to make clear it's only used for that purpose. BUG=591561 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1812733003 Cr-Commit-Position: refs/heads/master@{#381977} (cherry picked from commit c41aca7b408e13fdee88a3b39db1a93813bd9fc1) Committed: https://chromium.googlesource.com/chromium/src/+/0b7080ff51fc8f6c7bc0f2d6d60c158ede2fdf9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -29 lines) Patch
M cc/base/invalidation_region.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer.cc View 8 chunks +9 lines, -17 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 2 chunks +85 lines, -1 line 0 comments Download
M cc/playback/display_list_recording_source.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/playback/display_list_recording_source.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M cc/test/fake_display_list_recording_source.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
4 years, 9 months ago (2016-03-18 20:54:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0b7080ff51fc8f6c7bc0f2d6d60c158ede2fdf9b.

Powered by Google App Engine
This is Rietveld 408576698