Store recording invalidations in DisplayListRecordingSource, save them via Update.

Store recording invalidations in DisplayListRecordingSource, save them via Update.

This fixes the referenced bug, as well as cleaning up the interaction between
PictureLayer and DisplayListRecordingSource a little bit. This way both the
invalidation and picture come from DisplayListRecordingSource, rather than one
coming from PictureLayer and the other from DisplayListRecordingSource, with the
latter modifying the invalidation during Update.

Also renamed LayerImpl::GetInvalidationRegion() to
LayerImpl::GetInvalidationRegionForDebugging() to make clear it's only used for
that purpose.

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c41aca7b408e13fdee88a3b39db1a93813bd9fc1
Cr-Commit-Position: refs/heads/master@{#381977}

[chrishtr, 2016-03-17 21:08:38]

Description was changed from

==========
none


none


none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2016-03-17 21:09:48]

Description was changed from

==========
none


none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Move invalidation to DisplayListRecordingSource

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2016-03-17 21:57:55]

Description was changed from

==========
Move invalidation to DisplayListRecordingSource

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Store recording invalidations in DisplayListRecordingSource, save them via
Update.

This fixes the referenced bug, as well as cleaning up the interaction between
PictureLayer and DisplayListRecordingSource a little bit. This way both the
invalidation and picture come from DisplayListRecordingSource, rather than one
coming from PictureLayer and the other from DisplayListRecordingSource, with the
latter modifying the invalidation during Update.

Also renamed LayerImpl::GetInvalidationRegion() to
LayerImpl::GetInvalidationRegionForDebugging() to make clear it's only used for
that purpose.

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2016-03-17 22:03:17]

chrishtr@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2016-03-17 22:32:16]

lgtm

[chrishtr, 2016-03-17 22:32:37]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-03-17 22:33:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812733003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812733003/60001

[commit-bot: I haz the power, 2016-03-18 00:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:54:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-03-18 01:03:39]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-03-18 01:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812733003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812733003/60001

[commit-bot: I haz the power, 2016-03-18 02:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 02:36:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-03-18 15:00:55]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-03-18 15:01:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812733003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812733003/60001

[commit-bot: I haz the power, 2016-03-18 15:44:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-18 15:46:13]

Description was changed from

==========
Store recording invalidations in DisplayListRecordingSource, save them via
Update.

This fixes the referenced bug, as well as cleaning up the interaction between
PictureLayer and DisplayListRecordingSource a little bit. This way both the
invalidation and picture come from DisplayListRecordingSource, rather than one
coming from PictureLayer and the other from DisplayListRecordingSource, with the
latter modifying the invalidation during Update.

Also renamed LayerImpl::GetInvalidationRegion() to
LayerImpl::GetInvalidationRegionForDebugging() to make clear it's only used for
that purpose.

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Store recording invalidations in DisplayListRecordingSource, save them via
Update.

This fixes the referenced bug, as well as cleaning up the interaction between
PictureLayer and DisplayListRecordingSource a little bit. This way both the
invalidation and picture come from DisplayListRecordingSource, rather than one
coming from PictureLayer and the other from DisplayListRecordingSource, with the
latter modifying the invalidation during Update.

Also renamed LayerImpl::GetInvalidationRegion() to
LayerImpl::GetInvalidationRegionForDebugging() to make clear it's only used for
that purpose.

BUG=591561
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c41aca7b408e13fdee88a3b39db1a93813bd9fc1
Cr-Commit-Position: refs/heads/master@{#381977}
==========

[commit-bot: I haz the power, 2016-03-18 15:46:16]

Patchset 4 (id:??) landed as
https://crrev.com/c41aca7b408e13fdee88a3b39db1a93813bd9fc1
Cr-Commit-Position: refs/heads/master@{#381977}