cc/layers/picture_layer_impl_unittest.cc - Issue 1812733004: Store recording invalidations in DisplayListRecordingSource, save them via Update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 1812733004: Store recording invalidations in DisplayListRecordingSource, save them via Update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl_unittest.cc

diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc

index 04bac67a49b442f350f650fa5eb43c6caea69a89..e3fa5e964ab9aaf0a094e8ca593ed39f830a3a41 100644

--- a/cc/layers/picture_layer_impl_unittest.cc

+++ b/cc/layers/picture_layer_impl_unittest.cc

@@ -4531,7 +4531,8 @@ TEST_F(PictureLayerImplTest, NonSolidToSolidNoTilings) {

client.set_fill_with_nonsolid_color(true);

- Region invalidation1(layer_rect);

+ recording_source->SetNeedsDisplayRect(layer_rect);

+ Region invalidation1;

recording_source->UpdateAndExpandInvalidation(

&client, &invalidation1, layer_bounds, layer_rect, frame_number++,

DisplayListRecordingSource::RECORD_NORMALLY);

@@ -4550,7 +4551,8 @@ TEST_F(PictureLayerImplTest, NonSolidToSolidNoTilings) {

client.set_fill_with_nonsolid_color(false);

- Region invalidation2(layer_rect);

+ recording_source->SetNeedsDisplayRect(layer_rect);

+ Region invalidation2;

recording_source->UpdateAndExpandInvalidation(

&client, &invalidation2, layer_bounds, layer_rect, frame_number++,

DisplayListRecordingSource::RECORD_NORMALLY);

« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/layers/picture_layer_unittest.cc » ('j') | no next file with comments »