Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812613003: [DevTools] Fix to double wrapping IPv6 in square brackets (Closed)

Created:
4 years, 9 months ago by Allada-Google
Modified:
4 years, 9 months ago
Reviewers:
lushnikov, pfeldman, allada
CC:
chromium-reviews, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix to double wrapping IPv6 in square brackets Removed DevTools code that added square brackets around IPv6 addresses. Also adjusted test script to allow IPv6 localhost's [::1] ip address for testing. BUG=595443 R=lushnikov

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Messages

Total messages: 7 (4 generated)
lushnikov
lgtm https://codereview.chromium.org/1812613003/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html File third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html (right): https://codereview.chromium.org/1812613003/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html#newcode39 third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html:39: if (request.url !== "http://[::1]:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=") while we are here, ...
4 years, 9 months ago (2016-03-16 23:07:57 UTC) #1
allada
PTL
4 years, 9 months ago (2016-03-16 23:17:05 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:27:06 UTC) #7 
This CL has an open dependency (Issue 1798173003 Patch 100001). Please resolve
the dependency and try again.

Powered by Google App Engine
This is Rietveld 408576698