third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html - Issue 1812613003: [DevTools] Fix to double wrapping IPv6 in square brackets

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html

Issue 1812613003: [DevTools] Fix to double wrapping IPv6 in square brackets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/test_runner/web_test_proxy.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="inspector-test.js"></script>	3 <script src="inspector-test.js"></script>

4 <script src="network-test.js"></script>	4 <script src="network-test.js"></script>

5	5

6 <script>	6 <script>

7 function submit()	7 function submitIPv4()

8 {	8 {

	9 document.getElementById("submitForm").setAttribute("action", "http://127.0.0 .1:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2= #fragmentParam1=fragmentValue1&fragmentParam2=");

	10 document.getElementById("submit").click();

	11 }

	12

	13 function submitIPv6()

	14 {

	15 document.getElementById("submitForm").setAttribute("action", "http://[::1]:8 000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=#fra gmentParam1=fragmentValue1&fragmentParam2=");

9 document.getElementById("submit").click();	16 document.getElementById("submit").click();

10 }	17 }

11	18

12 function test()	19 function test()

13 {	20 {

14 InspectorTest.evaluateInPage("submit()");	21 InspectorTest.evaluateInPage("submitIPv4()");

15 InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.Ev entTypes.RequestFinished, onRequestFinished);	22 InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.Ev entTypes.RequestFinished, onRequestFinishedIPv4);

16	23

17 function onRequestFinished(event)	24 function onRequestFinishedIPv4(event)

18 {	25 {

19 var request = event.data;	26 var request = event.data;

20 if (request.url !== "http://127.0.0.1:8000/inspector/resources/post-targ et.cgi?queryParam1=queryValue1&queryParam2=")	27 if (request.url !== "http://127.0.0.1:8000/inspector/resources/post-targ et.cgi?queryParam1=queryValue1&queryParam2=")

21 return;	28 return;

22 InspectorTest.addObject(new WebInspector.HAREntry(request).build(), Insp ectorTest.HARPropertyFormatters);	29 InspectorTest.addObject(new WebInspector.HAREntry(request).build(), Insp ectorTest.HARPropertyFormatters);

	30

	31 InspectorTest.networkManager.removeEventListener(WebInspector.NetworkMan ager.EventTypes.RequestFinished, onRequestFinishedIPv4);

	32 InspectorTest.networkManager.addEventListener(WebInspector.NetworkManage r.EventTypes.RequestFinished, onRequestFinishedIPv6);

	33 InspectorTest.evaluateInPage("submitIPv6()");

	34 }

	35

	36 function onRequestFinishedIPv6(event)

	37 {

	38 var request = event.data;

	39 if (request.url !== "http://[::1]:8000/inspector/resources/post-target.c gi?queryParam1=queryValue1&queryParam2=")
	lushnikov 2016/03/16 23:07:56 while we are here, can we dump the URL instead of while we are here, can we dump the URL instead of the check?
	40 return;

	41 InspectorTest.addObject(new WebInspector.HAREntry(request).build(), Insp ectorTest.HARPropertyFormatters);

23 InspectorTest.completeTest();	42 InspectorTest.completeTest();

24 }	43 }

25 }	44 }

26	45

27 </script>	46 </script>

28 </head>	47 </head>

29 <body onload="runTest()">	48 <body onload="runTest()">

30 <p>	49 <p>

31 Tests that resources panel shows form data parameters.	50 Tests that resources panel shows form data parameters.

32 </p>	51 </p>

33 <form target="target-iframe" method="POST" action="http://127.0.0.1:8000/inspect or/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=#fragmentParam1 =fragmentValue1&fragmentParam2=">	52 <form id="submitForm" target="target-iframe" method="POST" action="">

34 <input name="formParam1" value="formValue1">	53 <input name="formParam1" value="formValue1">

35 <input name="formParam2">	54 <input name="formParam2">

36 <input id="submit" type="submit">	55 <input id="submit" type="submit">

37 </form>	56 </form>

38 <iframe name="target-iframe"></iframe>	57 <iframe name="target-iframe"></iframe>

39 </body>	58 </body>

40 </html>	59 </html>

OLD	NEW