Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html

Issue 1812613003: [DevTools] Fix to double wrapping IPv6 in square brackets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html b/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html
index 256b66b076614f2a2a1633ccff41438a3766f19f..62730dafede803609431efb3515f61ceab552c98 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html
@@ -4,21 +4,38 @@
<script src="network-test.js"></script>
<script>
-function submit()
+function submitIPv4()
{
+ document.getElementById("submitForm").setAttribute("action", "http://127.0.0.1:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=#fragmentParam1=fragmentValue1&fragmentParam2=");
+ document.getElementById("submit").click();
+}
+
+function submitIPv6()
+{
+ document.getElementById("submitForm").setAttribute("action", "http://[::1]:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=#fragmentParam1=fragmentValue1&fragmentParam2=");
document.getElementById("submit").click();
}
function test()
{
- InspectorTest.evaluateInPage("submit()");
- InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, onRequestFinished);
+ InspectorTest.evaluateInPage("submitIPv4()");
+ InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, onRequestFinishedIPv4);
+
+ function onRequestFinishedIPv4(event)
+ {
+ var request = event.data;
+ InspectorTest.addResult(request.url);
+ InspectorTest.addObject(new WebInspector.HAREntry(request).build(), InspectorTest.HARPropertyFormatters);
+
+ InspectorTest.networkManager.removeEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, onRequestFinishedIPv4);
+ InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, onRequestFinishedIPv6);
+ InspectorTest.evaluateInPage("submitIPv6()");
+ }
- function onRequestFinished(event)
+ function onRequestFinishedIPv6(event)
{
var request = event.data;
- if (request.url !== "http://127.0.0.1:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=")
- return;
+ InspectorTest.addResult(request.url);
InspectorTest.addObject(new WebInspector.HAREntry(request).build(), InspectorTest.HARPropertyFormatters);
InspectorTest.completeTest();
}
@@ -30,7 +47,7 @@ function test()
<p>
Tests that resources panel shows form data parameters.
</p>
-<form target="target-iframe" method="POST" action="http://127.0.0.1:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=#fragmentParam1=fragmentValue1&fragmentParam2=">
+<form id="submitForm" target="target-iframe" method="POST" action="">
<input name="formParam1" value="formValue1">
<input name="formParam2">
<input id="submit" type="submit">

Powered by Google App Engine
This is Rietveld 408576698