Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html

Issue 181233007: kiosk: Fix network check skipped regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: offline_enabled default value from webview permission Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html
diff --git a/chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html b/chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html
index d9a5638bc39463fb3fb19148bd913c3624b0b308..d0896dd460b5b11ce98783c59306461e83bf7988 100644
--- a/chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html
+++ b/chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html
@@ -5,3 +5,19 @@ Whether the app or extension is expected to work offline. When Chrome detects
that it is offline, apps with this field set to true will be highlighted
on the New Tab page.
</p>
+
not at google - send to devlin 2014/03/06 22:39:15 you should probably preface this somewhere with it
xiyuan 2014/03/06 23:41:01 Done.
+<p>
+Default values are provided for apps that do not speicify <code>"offline_enabled"</code>
not at google - send to devlin 2014/03/06 22:39:15 specify, though I think that you don't need this f
xiyuan 2014/03/06 23:41:01 Removed.
+in the manifest. Apps are assumed to be offline enabled and the default value
+of <code>"offline_enabled"</code> is <code>true</code> unless <code>"webview"</code>
+permission is requested. In this case, network connectivity is assumed to be
+required and <code>"offline_enabled"</code> defauts to <code>false</code>.
+</p>
+
+<p>
+The <code>"offline_enabled"</code> value is also used to determine whether a
+network connectivie check will be performed when launching an app in ChromeOS
not at google - send to devlin 2014/03/06 22:39:15 connectivity
xiyuan 2014/03/06 23:41:01 Done.
+kiosk mode. A network connectivity check will be performed when <code>"offline_enabled"</code>
not at google - send to devlin 2014/03/06 22:39:15 I'd leave out the "Chrome OS" part, but, up to you
xiyuan 2014/03/06 23:41:01 We need to document this somewhere. I'll keep it h
+is <code>false</code> and the app launching is on hold until the device obtains
not at google - send to devlin 2014/03/06 22:39:15 This might give the false impression that you actu
xiyuan 2014/03/06 23:41:01 Done.
+connectivity to the Internet.
+</p>
not at google - send to devlin 2014/03/06 22:39:15 Meggin could you go over this when you have time?

Powered by Google App Engine
This is Rietveld 408576698