chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc - Issue 181233007: kiosk: Fix network check skipped regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

Issue 181233007: kiosk: Fix network check skipped regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: offline_enabled default value from webview permission Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html ('K') | « chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html ('k') | chrome/test/data/chromeos/app_mode/kiosk_test_app/src/manifest.json » ('j') | extensions/common/manifest_handlers/offline_enabled_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

index 76c2b40e2fb0fded69fe76e07ba131508f907c61..be0628d621dc556e0b631b6ee26da751bc1b54ad 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

@@ -36,6 +36,9 @@ TEST_F(ExtensionManifestOfflineEnabledTest, OfflineEnabled) {

scoped_refptr<Extension> extension_5(

LoadAndExpectSuccess("offline_default_platform_app.json"));

EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_5.get()));

+ scoped_refptr<Extension> extension_6(

+ LoadAndExpectSuccess("offline_default_platform_app_with_webview.json"));

+ EXPECT_FALSE(OfflineEnabledInfo::IsOfflineEnabled(extension_6.get()));

}

} // namespace extensions