chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html - Issue 181233007: kiosk: Fix network check skipped regression.

Side by Side Diff: chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html

Issue 181233007: kiosk: Fix network check skipped regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: offline_enabled default value from webview permission Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/chromeos/login/kiosk_browsertest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc » ('j') | extensions/common/manifest_handlers/offline_enabled_info.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <h1 id="offline_enabled">Manifest - Offline Enabled</h1>	1 <h1 id="offline_enabled">Manifest - Offline Enabled</h1>

2	2

3 <p>	3 <p>

4 Whether the app or extension is expected to work offline. When Chrome detects	4 Whether the app or extension is expected to work offline. When Chrome detects

5 that it is offline, apps with this field set to true will be highlighted	5 that it is offline, apps with this field set to true will be highlighted

6 on the New Tab page.	6 on the New Tab page.

7 </p>	7 </p>

	8
	not at google - send to devlin 2014/03/06 22:39:15 you should probably preface this somewhere with it you should probably preface this somewhere with it being Chrome 35 onwards. xiyuan 2014/03/06 23:41:01 Done. Show quoted text On 2014/03/06 22:39:15, kalman wrote: > you should probably preface this somewhere with it being Chrome 35 onwards. Done.
	9 <p>

	10 Default values are provided for apps that do not speicify <code>"offline_enabled "</code>
	not at google - send to devlin 2014/03/06 22:39:15 specify, though I think that you don't need this f specify, though I think that you don't need this first sentence at all, it reads better without it. xiyuan 2014/03/06 23:41:01 Removed. Show quoted text On 2014/03/06 22:39:15, kalman wrote: > specify, though I think that you don't need this first sentence at all, it reads > better without it. Removed.
	11 in the manifest. Apps are assumed to be offline enabled and the default value

	12 of <code>"offline_enabled"</code> is <code>true</code> unless <code>"webview"</c ode>

	13 permission is requested. In this case, network connectivity is assumed to be

	14 required and <code>"offline_enabled"</code> defauts to <code>false</code>.

	15 </p>

	16

	17 <p>

	18 The <code>"offline_enabled"</code> value is also used to determine whether a

	19 network connectivie check will be performed when launching an app in ChromeOS
	not at google - send to devlin 2014/03/06 22:39:15 connectivity connectivity xiyuan 2014/03/06 23:41:01 Done. Show quoted text On 2014/03/06 22:39:15, kalman wrote: > connectivity Done.
	20 kiosk mode. A network connectivity check will be performed when <code>"offline_e nabled"</code>
	not at google - send to devlin 2014/03/06 22:39:15 I'd leave out the "Chrome OS" part, but, up to you I'd leave out the "Chrome OS" part, but, up to you. I'd definitely link to http://developer.chrome.com/apps/manifest/kiosk_enabled though. xiyuan 2014/03/06 23:41:01 We need to document this somewhere. I'll keep it h Show quoted text On 2014/03/06 22:39:15, kalman wrote: > I'd leave out the "Chrome OS" part, but, up to you. > > I'd definitely link to http://developer.chrome.com/apps/manifest/kiosk_enabled > though. We need to document this somewhere. I'll keep it here for now. Link added.
	21 is <code>false</code> and the app launching is on hold until the device obtains
	not at google - send to devlin 2014/03/06 22:39:15 This might give the false impression that you actu This might give the false impression that you actually need to set this value. I'd just say "A network connectivity check will be performed when apps are not offline enabled, and app launching put on hold..." xiyuan 2014/03/06 23:41:01 Done. Show quoted text On 2014/03/06 22:39:15, kalman wrote: > This might give the false impression that you actually need to set this value. > I'd just say "A network connectivity check will be performed when apps are not > offline enabled, and app launching put on hold..." Done.
	22 connectivity to the Internet.

	23 </p>
	not at google - send to devlin 2014/03/06 22:39:15 Meggin could you go over this when you have time? Meggin could you go over this when you have time? The existing content isn't very good.
OLD	NEW