Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812323003: Remove uses of SkImageDecoder from samplecode (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -80 lines) Patch
A samplecode/DecodeFile.h View 1 chunk +31 lines, -0 lines 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleBitmapRect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleCamera.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleConcavePaths.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleEmboss.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleFilter2.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M samplecode/SampleHairline.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M samplecode/SampleIdentityScale.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleLighting.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleLines.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SamplePatch.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SamplePath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePathClip.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePdfFileViewer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePictFile.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SamplePoints.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleRegion.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleShaders.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleSlides.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleSubpixelTranslate.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M samplecode/SampleText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleTextBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleUnpremul.cpp View 3 chunks +2 lines, -15 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
msarett
4 years, 9 months ago (2016-03-18 22:00:02 UTC) #3
scroggo
lgtm Love the simplicity. It's a little weird that we have a bunch of hardcoded ...
4 years, 9 months ago (2016-03-18 22:13:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812323003/1
4 years, 9 months ago (2016-03-18 22:28:58 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 22:48:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d15750c0c7766ecab7022ea9b2f9e89a9132cbc2

Powered by Google App Engine
This is Rietveld 408576698