chrome/android/java/res/layout/new_tab_page_scrollview.xml - Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_scrollview.xml

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/new_tab_page_recyclerview.xml ('K') | « chrome/android/java/res/layout/new_tab_page_recyclerview.xml ('k') | chrome/android/java/res/layout/new_tab_page_snippets_card.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page_scrollview.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_scrollview.xml b/chrome/android/java/res/layout/new_tab_page_scrollview.xml

new file mode 100644

index 0000000000000000000000000000000000000000..a36dd8d8fc97e89ca19fa8bc6564a00a515f3beb

--- /dev/null

+++ b/chrome/android/java/res/layout/new_tab_page_scrollview.xml

@@ -0,0 +1,20 @@

+<?xml version="1.0" encoding="utf-8"?>

mcwilliams 2016/03/21 12:45:50 Likewise here ...scroll_view.xml for naming conven

May 2016/03/23 19:22:55 Same, ScrollView is an Android element so prefer t

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<org.chromium.chrome.browser.ntp.NewTabScrollView

+ xmlns:android="http://schemas.android.com/apk/res/android"

+ xmlns:chrome="http://schemas.android.com/apk/res-auto"

newt (away) 2016/03/23 05:29:37 not needed

May 2016/03/23 19:22:55 Done.

+ android:background="@color/ntp_bg"

+ android:fillViewport="true"

+ android:layout_width="match_parent"

+ android:layout_height="match_parent"

+ android:layout_marginBottom="48dp"

+ android:focusable="true"

+ android:focusableInTouchMode="true"

+ android:contentDescription="@string/accessibility_new_tab_page" >

+ <include layout="@layout/new_tab_page_layout" />

+</org.chromium.chrome.browser.ntp.NewTabScrollView>