chrome/android/java/res/layout/new_tab_page_scrollview.xml - Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_scrollview.xml

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/new_tab_page_recyclerview.xml ('K') | « chrome/android/java/res/layout/new_tab_page_recyclerview.xml ('k') | chrome/android/java/res/layout/new_tab_page_snippets_card.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	mcwilliams 2016/03/21 12:45:50 Likewise here ...scroll_view.xml for naming conven Likewise here ...scroll_view.xml for naming conventions May 2016/03/23 19:22:55 Same, ScrollView is an Android element so prefer t Show quoted text On 2016/03/21 12:45:50, mcwilliams wrote: > Likewise here ...scroll_view.xml for naming conventions Same, ScrollView is an Android element so prefer to keep that globbed together.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.ntp.NewTabScrollView

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
	newt (away) 2016/03/23 05:29:37 not needed not needed May 2016/03/23 19:22:55 Done. Show quoted text On 2016/03/23 05:29:37, newt wrote: > not needed Done.
	9 android:background="@color/ntp_bg"

	10 android:fillViewport="true"

	11 android:layout_width="match_parent"

	12 android:layout_height="match_parent"

	13 android:layout_marginBottom="48dp"

	14 android:focusable="true"

	15 android:focusableInTouchMode="true"

	16 android:contentDescription="@string/accessibility_new_tab_page" >

	17

	18 <include layout="@layout/new_tab_page_layout" />

	19

	20 </org.chromium.chrome.browser.ntp.NewTabScrollView>

OLD	NEW