Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index dd5c437b371f3beb5b8acb58a6e6eaf22b6f577b..e4fa5e813d9536cd14cf309701665d2b6b334065 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -246,7 +246,8 @@ public class NewTabPage
@Override
public boolean isToolbarEnabled() {
- return ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_TOOLBAR);
+ return ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_TOOLBAR)
+ || ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS);
newt (away) 2016/03/23 05:29:37 Is this check backwards? I'd expect the toolbar to
May 2016/03/23 19:22:56 Wait... this is weird. I must not have uploaded a
}
private void recordOpenedMostVisitedItem(MostVisitedItem item) {
@@ -657,13 +658,8 @@ public class NewTabPage
}
private void updateSearchProviderHasLogo() {
- if (ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SNIPPETS)) {
- mSearchProviderHasLogo = false;
- if (mNewTabPageView != null) mNewTabPageView.setSearchProviderHasLogo(false);
- } else {
- mSearchProviderHasLogo = !mOptOutPromoShown
- && TemplateUrlService.getInstance().isDefaultSearchEngineGoogle();
- }
+ mSearchProviderHasLogo = !mOptOutPromoShown
+ && TemplateUrlService.getInstance().isDefaultSearchEngineGoogle();
}
private void onSearchEngineUpdated() {

Powered by Google App Engine
This is Rietveld 408576698