third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h ('K') | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h » ('j') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

index 4e039549b336653befb59e5034999e416304cb6f..4b469160e85ea0fe2114c0c85123a86eb684c8c6 100644

--- a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

@@ -6,6 +6,7 @@

#include "platform/SharedBuffer.h"

#include "platform/image-decoders/ImageDecoderTestHelpers.h"

+#include "platform/image-decoders/SharedBufferSegmentReader.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace blink {

@@ -26,7 +27,8 @@ TEST(BMPImageDecoderTest, isSizeAvailable)

ASSERT_TRUE(data.get());

OwnPtr<ImageDecoder> decoder = createDecoder();

- decoder->setData(data.get(), true);

+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));

+ decoder->setData(segmentReader.get(), true);

EXPECT_TRUE(decoder->isSizeAvailable());

EXPECT_EQ(256, decoder->size().width());

EXPECT_EQ(256, decoder->size().height());

@@ -39,7 +41,8 @@ TEST(BMPImageDecoderTest, parseAndDecode)

ASSERT_TRUE(data.get());

OwnPtr<ImageDecoder> decoder = createDecoder();

- decoder->setData(data.get(), true);

+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));

+ decoder->setData(segmentReader.get(), true);

ImageFrame* frame = decoder->frameBufferAtIndex(0);

ASSERT_TRUE(frame);

@@ -57,7 +60,8 @@ TEST(BMPImageDecoderTest, emptyImage)

ASSERT_TRUE(data.get());

OwnPtr<ImageDecoder> decoder = createDecoder();

- decoder->setData(data.get(), true);

+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));

+ decoder->setData(segmentReader.get(), true);

ImageFrame* frame = decoder->frameBufferAtIndex(0);

ASSERT_TRUE(frame);