Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h
diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h
index d2d95ab96583455e40a6548e9e1d9838757da68a..d8e6a1f0e87c7d71aca84f55cbe0b028c9c57f49 100644
--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h
+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h
@@ -30,6 +30,8 @@
#define WEBPImageDecoder_h
#include "platform/image-decoders/ImageDecoder.h"
+#include "skia/ext/refptr.h"
f(malita) 2016/03/23 16:41:58 wtf/RefPtr.h
scroggo_chromium 2016/03/24 13:59:46 Done.
+#include "third_party/skia/include/core/SkData.h"
#include "webp/decode.h"
#include "webp/demux.h"
@@ -44,7 +46,7 @@ public:
// ImageDecoder:
String filenameExtension() const override { return "webp"; }
bool hasColorProfile() const override { return m_hasColorProfile; }
- void onSetData(SharedBuffer* data) override;
+ void onSetData(SegmentReader* data) override;
int repetitionCount() const override;
bool frameIsCompleteAtIndex(size_t) const override;
float frameDurationAtIndex(size_t) const override;
@@ -90,6 +92,9 @@ private:
void clear();
void clearDecoder();
+
+ // FIXME: Update libwebp's API so it does not require copying the data on each update.
+ skia::RefPtr<SkData> m_encodedData;
f(malita) 2016/03/23 16:41:58 RefPtr<SkData>
scroggo_chromium 2016/03/24 13:59:46 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698