Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/image-decoders/bmp/BMPImageDecoder.h" 5 #include "platform/image-decoders/bmp/BMPImageDecoder.h"
6 6
7 #include "platform/SharedBuffer.h" 7 #include "platform/SharedBuffer.h"
8 #include "platform/image-decoders/ImageDecoderTestHelpers.h" 8 #include "platform/image-decoders/ImageDecoderTestHelpers.h"
9 #include "platform/image-decoders/SharedBufferSegmentReader.h"
9 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 namespace { 14 namespace {
14 15
15 PassOwnPtr<ImageDecoder> createDecoder() 16 PassOwnPtr<ImageDecoder> createDecoder()
16 { 17 {
17 return adoptPtr(new BMPImageDecoder(ImageDecoder::AlphaNotPremultiplied, Ima geDecoder::GammaAndColorProfileApplied, ImageDecoder::noDecodedImageByteLimit)); 18 return adoptPtr(new BMPImageDecoder(ImageDecoder::AlphaNotPremultiplied, Ima geDecoder::GammaAndColorProfileApplied, ImageDecoder::noDecodedImageByteLimit));
18 } 19 }
19 20
20 } // anonymous namespace 21 } // anonymous namespace
21 22
22 TEST(BMPImageDecoderTest, isSizeAvailable) 23 TEST(BMPImageDecoderTest, isSizeAvailable)
23 { 24 {
24 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp"; // 256 x256 25 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp"; // 256 x256
25 RefPtr<SharedBuffer> data = readFile(bmpFile); 26 RefPtr<SharedBuffer> data = readFile(bmpFile);
26 ASSERT_TRUE(data.get()); 27 ASSERT_TRUE(data.get());
27 28
28 OwnPtr<ImageDecoder> decoder = createDecoder(); 29 OwnPtr<ImageDecoder> decoder = createDecoder();
29 decoder->setData(data.get(), true); 30 RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferS egmentReader(data));
31 decoder->setData(segmentReader.get(), true);
30 EXPECT_TRUE(decoder->isSizeAvailable()); 32 EXPECT_TRUE(decoder->isSizeAvailable());
31 EXPECT_EQ(256, decoder->size().width()); 33 EXPECT_EQ(256, decoder->size().width());
32 EXPECT_EQ(256, decoder->size().height()); 34 EXPECT_EQ(256, decoder->size().height());
33 } 35 }
34 36
35 TEST(BMPImageDecoderTest, parseAndDecode) 37 TEST(BMPImageDecoderTest, parseAndDecode)
36 { 38 {
37 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp"; // 256 x256 39 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp"; // 256 x256
38 RefPtr<SharedBuffer> data = readFile(bmpFile); 40 RefPtr<SharedBuffer> data = readFile(bmpFile);
39 ASSERT_TRUE(data.get()); 41 ASSERT_TRUE(data.get());
40 42
41 OwnPtr<ImageDecoder> decoder = createDecoder(); 43 OwnPtr<ImageDecoder> decoder = createDecoder();
42 decoder->setData(data.get(), true); 44 RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferS egmentReader(data));
45 decoder->setData(segmentReader.get(), true);
43 46
44 ImageFrame* frame = decoder->frameBufferAtIndex(0); 47 ImageFrame* frame = decoder->frameBufferAtIndex(0);
45 ASSERT_TRUE(frame); 48 ASSERT_TRUE(frame);
46 EXPECT_EQ(ImageFrame::FrameComplete, frame->status()); 49 EXPECT_EQ(ImageFrame::FrameComplete, frame->status());
47 EXPECT_EQ(256, frame->getSkBitmap().width()); 50 EXPECT_EQ(256, frame->getSkBitmap().width());
48 EXPECT_EQ(256, frame->getSkBitmap().height()); 51 EXPECT_EQ(256, frame->getSkBitmap().height());
49 EXPECT_FALSE(decoder->failed()); 52 EXPECT_FALSE(decoder->failed());
50 } 53 }
51 54
52 // Test if a BMP decoder returns a proper error while decoding an empty image. 55 // Test if a BMP decoder returns a proper error while decoding an empty image.
53 TEST(BMPImageDecoderTest, emptyImage) 56 TEST(BMPImageDecoderTest, emptyImage)
54 { 57 {
55 const char* bmpFile = "/LayoutTests/fast/images/resources/0x0.bmp"; // 0x0 58 const char* bmpFile = "/LayoutTests/fast/images/resources/0x0.bmp"; // 0x0
56 RefPtr<SharedBuffer> data = readFile(bmpFile); 59 RefPtr<SharedBuffer> data = readFile(bmpFile);
57 ASSERT_TRUE(data.get()); 60 ASSERT_TRUE(data.get());
58 61
59 OwnPtr<ImageDecoder> decoder = createDecoder(); 62 OwnPtr<ImageDecoder> decoder = createDecoder();
60 decoder->setData(data.get(), true); 63 RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferS egmentReader(data));
64 decoder->setData(segmentReader.get(), true);
61 65
62 ImageFrame* frame = decoder->frameBufferAtIndex(0); 66 ImageFrame* frame = decoder->frameBufferAtIndex(0);
63 ASSERT_TRUE(frame); 67 ASSERT_TRUE(frame);
64 EXPECT_EQ(ImageFrame::FrameEmpty, frame->status()); 68 EXPECT_EQ(ImageFrame::FrameEmpty, frame->status());
65 EXPECT_TRUE(decoder->failed()); 69 EXPECT_TRUE(decoder->failed());
66 } 70 }
67 71
68 // This test verifies that calling SharedBuffer::mergeSegmentsIntoBuffer() does 72 // This test verifies that calling SharedBuffer::mergeSegmentsIntoBuffer() does
69 // not break BMP decoding at a critical point: in between a call to decode the 73 // not break BMP decoding at a critical point: in between a call to decode the
70 // size (when BMPImageDecoder stops while it may still have input data to 74 // size (when BMPImageDecoder stops while it may still have input data to
71 // read) and a call to do a full decode. 75 // read) and a call to do a full decode.
72 TEST(BMPImageDecoderTest, mergeBuffer) 76 TEST(BMPImageDecoderTest, mergeBuffer)
73 { 77 {
74 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp"; 78 const char* bmpFile = "/LayoutTests/fast/images/resources/lenna.bmp";
75 testMergeBuffer(&createDecoder, bmpFile); 79 testMergeBuffer(&createDecoder, bmpFile);
76 } 80 }
77 81
78 } // namespace blink 82 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698