third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/SkDataSegmentReader.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/SkDataSegmentReader.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

index c2053a50d299e1ff4bd969b3c49a87902a30e4eb..e4a6bd15b94a983316826e101838dd874e38f7bf 100644

--- a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

@@ -43,7 +43,7 @@ public:

// ImageDecoder:

String filenameExtension() const override { return "bmp"; }

- void onSetData(SharedBuffer*) override;

+ void onSetData(SegmentReader*) override;

f(malita) 2016/03/23 16:41:58 Should likely be PassRefPtr<SegmentReader>. Here

scroggo_chromium 2016/03/24 13:59:46 +1 for making this a separate CL :)

// CAUTION: setFailed() deletes |m_reader|. Be careful to avoid

// accessing deleted memory, especially when calling this from inside

// BMPImageReader!