Eliminate copies of encoded image data

third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h

 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 
 namespace blink {
 
 // This class decodes the BMP image format.
 class PLATFORM_EXPORT BMPImageDecoder final : public ImageDecoder {
 public:
     BMPImageDecoder(AlphaOption, GammaAndColorProfileOption, size_t maxDecodedBytes);
 
     // ImageDecoder:
     String filenameExtension() const override { return "bmp"; }
-    void onSetData(SharedBuffer*) override;
+    void onSetData(SegmentReader*) override;

[f(malita), 2016/03/23 16:41:58]

Should likely be PassRefPtr<SegmentReader>.

Here and all other decoders... hmm, I expect this interface change will be
noisy, so maybe it should be a separate CL.

[scroggo_chromium, 2016/03/24 13:59:46]

+1 for making this a separate CL :)

     // CAUTION: setFailed() deletes |m_reader|.  Be careful to avoid
     // accessing deleted memory, especially when calling this from inside
     // BMPImageReader!
     bool setFailed() override;
 
 private:
     // ImageDecoder:
     void decodeSize() override { decode(true); }
     void decode(size_t) override { decode(false); }
 
@@ skipping 16 matching lines @@
     // BMPImageReader takes over this will not be updated further.
     size_t m_decodedOffset;
 
     // The reader used to do most of the BMP decoding.
     OwnPtr<BMPImageReader> m_reader;
 };
 
 } // namespace blink
 
 #endif