Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 18120006: Revert 209112 "Revert 209071 "components/webdata: Break the depe..." (Closed)

Created:
7 years, 5 months ago by kinuko
Modified:
7 years, 5 months ago
Reviewers:
sail
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 209112 "Revert 209071 "components/webdata: Break the depe..." Broke the tree. > Revert 209071 "components/webdata: Break the dependency on chrom..." > > speculative revert to see if it fixes the android bots. > > > components/webdata: Break the dependency on chrome/test/base > > > > BUG=181277 > > TBR=joi@chromium.org > > > > Review URL: https://codereview.chromium.org/17788002 > > TBR=tfarina@chromium.org > > Review URL: https://codereview.chromium.org/18177003 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M trunk/src/build/android/pylib/gtest/test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/unit_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/components/webdata/DEPS View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/components/webdata/common/web_database_migration_unittest.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 5 months ago (2013-06-28 06:48:46 UTC) #1
kinuko
7 years, 5 months ago (2013-06-28 06:49:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r209115.

Powered by Google App Engine
This is Rietveld 408576698