Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17788002: components/webdata: Break the dependency on chrome/test/base (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
csharp, Jói
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

components/webdata: Break the dependency on chrome/test/base BUG=181277 TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209071

Patch Set 1 #

Patch Set 2 : rm deps entry #

Patch Set 3 : rm files from c/t/d/web_database #

Patch Set 4 : fix android? #

Patch Set 5 : add entry to chrome/unit_tests.isolate to fix swarm build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-14 lines, -926 lines) Patch
M build/android/pylib/gtest/test_runner.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D chrome/test/data/web_database/version_22.sql View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/web_database/version_22_corrupt.sql View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/test/data/web_database/version_25.sql View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/test/data/web_database/version_26.sql View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/test/data/web_database/version_27.sql View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/web_database/version_29.sql View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/data/web_database/version_30.sql View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/web_database/version_31.sql View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/data/web_database/version_32.sql View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/web_database/version_33.sql View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/test/data/web_database/version_34.sql View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/test/data/web_database/version_35.sql View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/test/data/web_database/version_37.sql View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/web_database/version_38.sql View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/web_database/version_39.sql View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/web_database/version_40.sql View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/data/web_database/version_41.sql View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/data/web_database/version_42.sql View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/data/web_database/version_43.sql View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/web_database/version_44.sql View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/data/web_database/version_45.sql View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/data/web_database/version_45_compatible.sql View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/data/web_database/version_45_invalid.sql View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/data/web_database/version_46.sql View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/web_database/version_47.sql View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/data/web_database/version_48.sql View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/web_database/version_49.sql View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/unit_tests.isolate View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + components/test/data/web_database/version_22.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_22_corrupt.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_25.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_26.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_27.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_29.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_30.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_31.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_32.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_33.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_34.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_35.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_37.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_38.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_39.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_40.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_41.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_42.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_43.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_44.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_45.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_45_compatible.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_45_invalid.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_46.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_47.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_48.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/web_database/version_49.sql View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M components/webdata/DEPS View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
7 years, 6 months ago (2013-06-26 03:19:03 UTC) #1
Jói
Looks like you're copying the .sql files but not deleting the old location. Let's not ...
7 years, 6 months ago (2013-06-26 13:19:27 UTC) #2
tfarina
Removed. PTAL.
7 years, 5 months ago (2013-06-26 21:35:57 UTC) #3
Jói
LGTM, thanks.
7 years, 5 months ago (2013-06-27 11:10:15 UTC) #4
tfarina
TBRing Chris for chrome/unit_tests.isolate
7 years, 5 months ago (2013-06-28 02:17:37 UTC) #5
tfarina
Committed patchset #5 manually as r209071 (presubmit successful).
7 years, 5 months ago (2013-06-28 02:19:43 UTC) #6
csharp
7 years, 5 months ago (2013-06-28 12:44:06 UTC) #7
Message was sent while issue was closed. 
On 2013/06/28 02:19:43, tfarina wrote:
> Committed patchset #5 manually as r209071 (presubmit successful).

unit_tests.isolate LGTM

Powered by Google App Engine
This is Rietveld 408576698