Issue 18177003: Revert 209071 "components/webdata: Break the dependency on chrom..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18177003: Revert 209071 "components/webdata: Break the dependency on chrom..." (Closed)

Created:
7 years, 5 months ago by sail

Modified:
7 years, 5 months ago

Reviewers:
tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 209071 "components/webdata: Break the dependency on chrom..." speculative revert to see if it fixes the android bots. > components/webdata: Break the dependency on chrome/test/base > > BUG=181277 > TBR=joi@chromium.org > > Review URL: https://codereview.chromium.org/17788002 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209112

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -956 lines)			Patch
M	trunk/src/build/android/pylib/gtest/test_runner.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/unit_tests.isolate	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/components/test/data/web_database/version_22.sql	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_22_corrupt.sql	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_25.sql	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_26.sql	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_27.sql	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_29.sql	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_30.sql	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_31.sql	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_32.sql	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_33.sql	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_34.sql	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_35.sql	View	1 chunk	+0 lines, -59 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_37.sql	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_38.sql	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_39.sql	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_40.sql	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_41.sql	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_42.sql	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_43.sql	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_44.sql	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_45.sql	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_45_compatible.sql	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_45_invalid.sql	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_46.sql	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_47.sql	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_48.sql	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/components/test/data/web_database/version_49.sql	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	trunk/src/components/webdata/DEPS	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	trunk/src/components/webdata/common/web_database_migration_unittest.cc	View	3 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r209112.

Expand Messages | Collapse Messages