Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not overflow.

Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a timestamp. With the exception of SkMovie, which is used in Android, all of the uses appear to measure the execution time of a piece of code, which I would hope does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to measure the wallclock time in integer milliseconds. (Not used in tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811613004

Committed: https://skia.googlesource.com/skia/+/ec4d4d784dbb250e572f8e04d18d0fd2ebeee851

[dogben, 2016-03-17 17:27:22]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

BUG=skia:4632
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 17:32:58]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SkAutoTime

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 17:37:02]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SkAutoTime

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 18:31:09]

Patchset #1 (id:1) has been deleted

[dogben, 2016-03-17 18:31:18]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 18:31:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/20001

[commit-bot: I haz the power, 2016-03-17 18:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 18:51:39]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-17 19:29:48]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left uses of SkMSec used to measure a duration rather than a timestamp.
All of the uses appear to measure the execution time of a piece of code, which I
would hope does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 19:31:15]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left uses of SkMSec used to measure a duration rather than a timestamp.
All of the uses appear to measure the execution time of a piece of code, which I
would hope does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a
timestamp. All of the uses appear to measure the execution time of a piece of
code, which I would hope does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 19:32:49]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a
timestamp. All of the uses appear to measure the execution time of a piece of
code, which I would hope does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a
timestamp. With the exception of SkMovie, which is used in Android, all of the
uses appear to measure the execution time of a piece of code, which I would hope
does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-17 19:46:55]

benjaminwagner@google.com changed reviewers:
+ mtklein@google.com

[dogben, 2016-03-18 19:13:35]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 19:13:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/40001

[commit-bot: I haz the power, 2016-03-18 19:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:15:50]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein, 2016-03-22 13:35:39]

lgtm

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h
File include/core/SkTime.h (right):

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h#n...
include/core/SkTime.h:37: static double GetSecs() { return GetNSecs() * 1e-9; }
Didn't catch anywhere this was used?

[mtklein, 2016-03-22 13:35:40]

lgtm

lgtm

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h
File include/core/SkTime.h (right):

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h#n...
include/core/SkTime.h:37: static double GetSecs() { return GetNSecs() * 1e-9; }
Didn't catch anywhere this was used?

[dogben, 2016-03-22 17:12:51]

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h
File include/core/SkTime.h (right):

https://codereview.chromium.org/1811613004/diff/40001/include/core/SkTime.h#n...
include/core/SkTime.h:37: static double GetSecs() { return GetNSecs() * 1e-9; }
On 2016/03/22 at 13:35:40, mtklein wrote:
> Didn't catch anywhere this was used?

It's used in src/views/SkTouchGesture.cpp, but I'm happy to manually inline
that.

[mtklein, 2016-03-22 17:25:52]

> It's used in src/views/SkTouchGesture.cpp, but I'm happy to manually inline
> that.

Ah, either way's fine by me.

[dogben, 2016-03-22 17:30:28]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 17:30:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/60001

[commit-bot: I haz the power, 2016-03-22 17:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 17:49:18]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-22 17:56:53]

The CQ bit was checked by benjaminwagner@google.com

[dogben, 2016-03-22 17:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1811613004/#ps60001
(title: "Fix bad merge.")

[commit-bot: I haz the power, 2016-03-22 17:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/60001

[commit-bot: I haz the power, 2016-03-22 17:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 17:58:27]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[dogben, 2016-03-22 18:00:55]

benjaminwagner@google.com changed reviewers:
+ reed@google.com

[dogben, 2016-03-24 23:32:56]

reed, PTAL at API changes:
 - Addition of SkTime::GetSecs.
 - Change return type of SkTime::GetMSecs.
 - Remove 2nd arg to SkAutoTime.
 - Addition of SkEvent::GetMSecsSinceStartup

[reed1, 2016-03-25 12:33:12]

lgtm

[dogben, 2016-03-25 13:59:34]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-03-25 13:59:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/60001

[commit-bot: I haz the power, 2016-03-25 14:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 14:00:52]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[dogben, 2016-03-25 19:44:52]

The CQ bit was checked by benjaminwagner@google.com

[dogben, 2016-03-25 19:44:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1811613004/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-25 19:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811613004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811613004/80001

[commit-bot: I haz the power, 2016-03-25 19:59:55]

Description was changed from

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a
timestamp. With the exception of SkMovie, which is used in Android, all of the
uses appear to measure the execution time of a piece of code, which I would hope
does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not
overflow.

The following are currently unused in Android, Google3, Chromium, and Mozilla:
  - SkEvent
  - SkTime::GetMSecs
  - SK_TIME_FACTOR (also unused in Skia)
  - SkAutoTime

I left uses of SkMSec more-or-less intact for SkEvent, SkAnimator, and
SkInterpolator. SkInterpolator is used in Chromium, so I did not want to change
the API. The views/ and animator/ code is crufty, so it didn't seem worthwhile
to refactor it. Instead, I added SkEvent::GetMSecsSinceStartup, which is likely
to be adequate for use in SampleApp.

I also left SkMSec where it is used to measure a duration rather than a
timestamp. With the exception of SkMovie, which is used in Android, all of the
uses appear to measure the execution time of a piece of code, which I would hope
does not exceed 2^31 milliseconds.

Added skiatest::Timer to support a common idiom in tests where we want to
measure the wallclock time in integer milliseconds. (Not used in
tests/PathOpsSkpClipTest.cpp because it redefines things in Test.h.)

Removed tabs in tests/StrokerTest.cpp.

BUG=skia:4632
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ec4d4d784dbb250e572f8e04d18d0fd2ebeee851
==========

[commit-bot: I haz the power, 2016-03-25 19:59:56]

Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/ec4d4d784dbb250e572f8e04d18d0fd2ebeee851