src/pdf/SkPDFMetadata.cpp - Issue 1811613004: Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFMetadata.cpp

Issue 1811613004: Change SkTime::GetMSecs to double; ensure values stored in SkMSec do not overflow. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/pdf/SkPDFMetadata.cpp

diff --git a/src/pdf/SkPDFMetadata.cpp b/src/pdf/SkPDFMetadata.cpp

index 5e8c124d7b6cb5d3351d4f095710ffd83fc061c0..118cda39fe9fb53b3cb91c6f20b7c08bc56e5d06 100644

--- a/src/pdf/SkPDFMetadata.cpp

+++ b/src/pdf/SkPDFMetadata.cpp

@@ -55,7 +55,7 @@ SkPDFMetadata::UUID SkPDFMetadata::uuid() const {

SkMD5 md5;

const char uuidNamespace[] = "org.skia.pdf\n";

md5.write(uuidNamespace, strlen(uuidNamespace));

- SkMSec msec = SkTime::GetMSecs();

+ double msec = SkTime::GetMSecs();

md5.write(&msec, sizeof(msec));

SkTime::DateTime dateTime;

SkTime::GetDateTime(&dateTime);

« no previous file with comments | « src/animator/SkAnimateMaker.cpp ('k') | src/views/SkEvent.cpp » ('j') | no next file with comments »