Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1811483003: Remove support for Root identity singletons and rely on the all_users bit to be set. + test (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@54login2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for Root identity singletons and rely on the all_users bit to be set. + test . set this bit on mus so we don't try to create per-user instances of it now that running it as root has no superpower. R=sky@chromium.org Committed: https://crrev.com/91adec57fa0a1765e1ec1053e6460f5ea96450ba Cr-Commit-Position: refs/heads/master@{#381516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -26 lines) Patch
M components/mus/manifest.json View 1 chunk +7 lines, -1 line 0 comments Download
M mojo/shell/shell.h View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/shell/shell.cc View 3 chunks +11 lines, -19 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittests_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-16 16:58:18 UTC) #1
sky
LGTM
4 years, 9 months ago (2016-03-16 17:17:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811483003/1
4 years, 9 months ago (2016-03-16 18:05:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:07:03 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:08:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91adec57fa0a1765e1ec1053e6460f5ea96450ba
Cr-Commit-Position: refs/heads/master@{#381516}

Powered by Google App Engine
This is Rietveld 408576698