Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810713002: Cascade shutdown of instances (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@55all_users
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cascade shutdown of instances BUG= Committed: https://crrev.com/d146bb0affa82f8a910fe99d23845ed542395ebe Cr-Commit-Position: refs/heads/master@{#381660}

Patch Set 1 #

Patch Set 2 : , #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -74 lines) Patch
M ash/mus/sysui_application.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/sysui_application.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/resource_provider/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 2 3 4 chunks +12 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 3 3 chunks +11 lines, -7 lines 0 comments Download
M mash/init/init.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M mash/init/init.cc View 1 2 3 3 chunks +26 lines, -8 lines 0 comments Download
M mash/login/login.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/login/public/interfaces/login.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mash/login/ui.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M mash/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/shell/public/interfaces/shell.mojom View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/services/catalog/manifest.json View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M mojo/services/tracing/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/shell/manifest.json View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M mojo/shell/shell.h View 1 2 3 4 5 3 chunks +7 lines, -9 lines 0 comments Download
M mojo/shell/shell.cc View 1 2 3 4 5 6 11 chunks +68 lines, -29 lines 0 comments Download
M mojo/shell/tests/connect/BUILD.gn View 1 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app_manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/shell/tests/connect/connect_test_singleton_app.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/shell/tests/connect/connect_test_singleton_app_manifest.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 2 chunks +12 lines, -7 lines 0 comments Download
M mojo/shell/tests/lifecycle/BUILD.gn View 1 2 chunks +22 lines, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/app_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/app_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.mojom View 1 1 chunk +9 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/parent.cc View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/parent_manifest.json View 1 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1806203002 Patch 1

Messages

Total messages: 22 (12 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-16 21:57:11 UTC) #2
sky
LGTM https://codereview.chromium.org/1810713002/diff/10022/mash/init/init.h File mash/init/init.h (right): https://codereview.chromium.org/1810713002/diff/10022/mash/init/init.h#newcode56 mash/init/init.h:56: const std::string login_user_id_; I don't think you're using ...
4 years, 9 months ago (2016-03-16 22:06:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810713002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810713002/50001
4 years, 9 months ago (2016-03-16 23:02:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/140769)
4 years, 9 months ago (2016-03-16 23:20:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810713002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810713002/70001
4 years, 9 months ago (2016-03-17 00:03:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/182470)
4 years, 9 months ago (2016-03-17 00:34:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810713002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810713002/90001
4 years, 9 months ago (2016-03-17 03:31:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810713002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810713002/110001
4 years, 9 months ago (2016-03-17 03:35:22 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 9 months ago (2016-03-17 04:40:09 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 04:42:02 UTC) #22
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/d146bb0affa82f8a910fe99d23845ed542395ebe
Cr-Commit-Position: refs/heads/master@{#381660}

Powered by Google App Engine
This is Rietveld 408576698