Restructure login

Restructure login

BUG=

Committed: https://crrev.com/f1e8fe46d99e15abe6f2b3270fe65ade9269997d
Cr-Commit-Position: refs/heads/master@{#381494}

[Ben Goodger (Google), 2016-03-15 20:16:16]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-15 20:33:51]

https://codereview.chromium.org/1801133002/diff/40001/mash/login/login.cc
File mash/login/login.cc (right):

https://codereview.chromium.org/1801133002/diff/40001/mash/login/login.cc#new...
mash/login/login.cc:74: new Login(connector_, this,
connection->GetRemoteIdentity().user_id(),
Doesn't this leak?

[Ben Goodger (Google), 2016-03-16 04:56:53]

OK I updated this and it works marvellously. I can sign in as Timothy, return to
the login screen, sign in as Jimothy, return to the login screen, sign in as
Timothy & Timothy's windows are still there and on and on.

I made a change to the Shell to introduce a new capability: "all_users". When an
app sets this bit, it's available to be connected to by all users. I think this
is the generic form of the shell's handling of the root user. If we like this, I
can go ahead and remove the special root handling and just replace it with this
(e.g. Mus would set this bit).

[sky, 2016-03-16 15:24:02]

This seems fine to me. Please document all_users some where, and especially what
that means for the app.

https://codereview.chromium.org/1801133002/diff/120001/mash/login/login.cc
File mash/login/login.cc (right):

https://codereview.chromium.org/1801133002/diff/120001/mash/login/login.cc#ne...
mash/login/login.cc:74: new Login(connector_, this,
connection->GetRemoteIdentity().user_id(),
Doesn't this leak?

https://codereview.chromium.org/1801133002/diff/120001/mojo/shell/shell.h
File mojo/shell/shell.h (right):

https://codereview.chromium.org/1801133002/diff/120001/mojo/shell/shell.h#new...
mojo/shell/shell.h:181: std::set<std::string> singletons_;
Add a description of this.

https://codereview.chromium.org/1801133002/diff/120001/ui/views/mus/window_ma...
File ui/views/mus/window_manager_connection.cc (right):

https://codereview.chromium.org/1801133002/diff/120001/ui/views/mus/window_ma...
ui/views/mus/window_manager_connection.cc:42: //  DCHECK(connection);
Did you intend to comment this out?

[Ben Goodger (Google), 2016-03-16 16:25:53]

Updated.

https://codereview.chromium.org/1801133002/diff/120001/mash/login/login.cc
File mash/login/login.cc (right):

https://codereview.chromium.org/1801133002/diff/120001/mash/login/login.cc#ne...
mash/login/login.cc:74: new Login(connector_, this,
connection->GetRemoteIdentity().user_id(),
On 2016/03/16 15:24:01, sky wrote:
> Doesn't this leak?

I switched it to StrongBinding.

[sky, 2016-03-16 16:47:05]

LGTM

[Ben Goodger (Google), 2016-03-16 17:02:56]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-16 17:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1801133002/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-03-16 17:03:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801133002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801133002/160001

[commit-bot: I haz the power, 2016-03-16 18:03:07]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-16 18:04:53]

Description was changed from

==========
Restructure login

BUG=
==========

to

==========
Restructure login

BUG=

Committed: https://crrev.com/f1e8fe46d99e15abe6f2b3270fe65ade9269997d
Cr-Commit-Position: refs/heads/master@{#381494}
==========

[commit-bot: I haz the power, 2016-03-16 18:04:54]

Patchset 9 (id:??) landed as
https://crrev.com/f1e8fe46d99e15abe6f2b3270fe65ade9269997d
Cr-Commit-Position: refs/heads/master@{#381494}