DataUseTabModel should check the URL to differentiate history navigation

DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909
Committed: https://crrev.com/690edcb456f6b6271a0c9330c2680e9812a61590
Cr-Commit-Position: refs/heads/master@{#381873}

[Raj, 2016-03-17 22:54:42]

rajendrant@chromium.org changed reviewers:
+ tbansal@chromium.org

[Raj, 2016-03-17 22:54:42]

ptal

[tbansal1, 2016-03-17 23:16:53]

You can improve on the CL description. Instead of saying, how you are doing it
("In addition to transition == PAGE_TRANSITION_AUTO_TOPLEVE, URL should be
checked to make sure its a history navigation."), you just need to mention what
is the effect of this CL.

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/data_use_ui_tab_model.cc (right):

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/data_use_ui_tab_model.cc:237: if (gurl ==
GURL(kChromeUIHistoryFrameURL)) {
why not kChromeUIHistoryURL?

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/data_use_ui_tab_model.h (right):

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/data_use_ui_tab_model.h:127: // Converts
transition |page_transition| for page url |gurl| to
s/Converts transition |page_transition| for page url |gurl| to/
Converts |page_transition| to page with GURL |gurl| to/

[Raj, 2016-03-18 00:35:42]

Description was changed from

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

In addition to transition == PAGE_TRANSITION_AUTO_TOPLEVE, URL should be
checked to make sure its a history navigation.

BUG=595909
==========

to

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

The page URL should be checked to make sure its a history navigation.

BUG=595909
==========

[Raj, 2016-03-18 00:37:10]

Description was changed from

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

The page URL should be checked to make sure its a history navigation.

BUG=595909
==========

to

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909
==========

[Raj, 2016-03-18 00:45:49]

Thanks for looking into.

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/data_use_ui_tab_model.cc (right):

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/data_use_ui_tab_model.cc:237: if (gurl ==
GURL(kChromeUIHistoryFrameURL)) {
On 2016/03/17 23:16:53, tbansal1 wrote:
> why not kChromeUIHistoryURL?

Added kChromeUIHistoryURL as well. It is weird. Clicking on 'History' and
selecting continue in the exit interstitial, navigates to
kChromeUIHistoryFrameURL. In other cases, it navigates to kChromeUIHistoryURL.

This browsertest also seem to be using kChromeUIHistoryFrameURL.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/data_use_ui_tab_model.h (right):

https://codereview.chromium.org/1811173002/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/data_use_ui_tab_model.h:127: // Converts
transition |page_transition| for page url |gurl| to
On 2016/03/17 23:16:53, tbansal1 wrote:
> s/Converts transition |page_transition| for page url |gurl| to/
> Converts |page_transition| to page with GURL |gurl| to/

Done.

[tbansal1, 2016-03-18 00:48:34]

lgtm

[Raj, 2016-03-18 01:32:49]

The CQ bit was checked by rajendrant@chromium.org

[commit-bot: I haz the power, 2016-03-18 01:33:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811173002/20001

[commit-bot: I haz the power, 2016-03-18 02:17:09]

Description was changed from

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909
==========

to

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909
==========

[commit-bot: I haz the power, 2016-03-18 02:17:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 02:19:32]

Description was changed from

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909
==========

to

==========
DataUseTabModel should check the URL to differentiate history navigation

PAGE_TRANSITION_AUTO_TOPLEVEL is used to indicate a wide variety of
transitions. For example, New page transitions
(https://codereview.chromium.org/1397673004), EmbedContentViewActivity.

BUG=595909

Committed: https://crrev.com/690edcb456f6b6271a0c9330c2680e9812a61590
Cr-Commit-Position: refs/heads/master@{#381873}
==========

[commit-bot: I haz the power, 2016-03-18 02:19:33]

Patchset 2 (id:??) landed as
https://crrev.com/690edcb456f6b6271a0c9330c2680e9812a61590
Cr-Commit-Position: refs/heads/master@{#381873}