Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4767)

Unified Diff: chrome/browser/android/data_usage/data_use_ui_tab_model.h

Issue 1811173002: DataUseTabModel should check the URL to differentiate history navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tbansal comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_ui_tab_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/data_usage/data_use_ui_tab_model.h
diff --git a/chrome/browser/android/data_usage/data_use_ui_tab_model.h b/chrome/browser/android/data_usage/data_use_ui_tab_model.h
index 34838b8d3ed6f2bbfab1683b29a7e0367ca210c0..ee34298c8693a4cefd759cfe0fd99fc3353c683b 100644
--- a/chrome/browser/android/data_usage/data_use_ui_tab_model.h
+++ b/chrome/browser/android/data_usage/data_use_ui_tab_model.h
@@ -124,12 +124,13 @@ class DataUseUITabModel : public KeyedService,
// returns true. Otherwise, returns false without modifying the entry.
bool RemoveTabEvent(SessionID::id_type tab_id, DataUseTrackingEvent event);
- // Converts |page_transition| to DataUseTabModel::TransitionType enum.
- // Returns true if conversion was successful, and updates |transition_type|.
- // Otherwise, returns false, and |transition_type| is not changed.
- // |transition_type| must not be null.
+ // Converts |page_transition| to page with GURL |gurl| to
+ // DataUseTabModel::TransitionType enum. Returns true if conversion was
+ // successful, and updates |transition_type|. Otherwise, returns false, and
+ // |transition_type| is not changed. |transition_type| must not be null.
bool ConvertTransitionType(
ui::PageTransition page_transition,
+ const GURL& gurl,
DataUseTabModel::TransitionType* transition_type) const;
// |tab_events_| stores tracking events of multiple tabs.
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_ui_tab_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698