Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.

Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.

This CL changes the page transition type for opening the NTP from
PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically,
this makes sense because the new tab is content automatically loaded
into a top level frame and the user did not 'type' chrome://newtab.

This change was made to distinguish between actual direct URL navigations
and opening a new tab when considering whether the Site Engagement Service
should award the origin engagement points.

BUG=543358
Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b
Cr-Commit-Position: refs/heads/master@{#354404}

[calamity, 2015-10-15 03:04:38]

calamity@chromium.org changed reviewers:
+ msw@chromium.org

[calamity, 2015-10-15 03:04:38]

+msw for OWNERS.

[msw, 2015-10-15 17:33:59]

lgtm

[calamity, 2015-10-15 22:44:37]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-10-15 22:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397673004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397673004/1

[commit-bot: I haz the power, 2015-10-15 23:45:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-15 23:46:02]

Patchset 1 (id:??) landed as
https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b
Cr-Commit-Position: refs/heads/master@{#354404}

[calamity, 2016-01-31 23:59:36]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1650923002/ by calamity@chromium.org.

The reason for reverting is: This CL breaks the tab focus stack for new tabs.
This patch should account for this and add a test for the existing behavior..

[calamity, 2016-02-01 02:53:09]

Description was changed from

==========
Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.

This CL changes the page transition type for opening the NTP from
PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically,
this makes sense because the new tab is content automatically loaded
into a top level frame and the user did not 'type' chrome://newtab.

This change was made to distinguish between actual direct URL navigations
and opening a new tab when considering whether the Site Engagement Service
should award the origin engagement points.

BUG=543358

Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b
Cr-Commit-Position: refs/heads/master@{#354404}
==========

to

==========
Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.

This CL changes the page transition type for opening the NTP from
PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically,
this makes sense because the new tab is content automatically loaded
into a top level frame and the user did not 'type' chrome://newtab.

This change was made to distinguish between actual direct URL navigations
and opening a new tab when considering whether the Site Engagement Service
should award the origin engagement points.

BUG=543358

Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b
Cr-Commit-Position: refs/heads/master@{#354404}
==========

[calamity, 2016-02-02 01:19:40]

Hey, this CL broke something so I reverted it. Reuploaded with a fix and test.
PTAL, thanks!

[msw, 2016-02-02 01:57:46]

It's good practice to create a new issue when re-landing an update CL.
(upload the reverted change first, then more patch sets with fixes)

https://codereview.chromium.org/1397673004/diff/40001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_tabstrip.cc (right):

https://codereview.chromium.org/1397673004/diff/40001/chrome/browser/ui/brows...
chrome/browser/ui/browser_tabstrip.cc:33: // Explicitly ensure new tabs will
return to the previous focused tabs when
nit: "Ensure the previously active tab regains focus when the new tab closes."

https://codereview.chromium.org/1397673004/diff/40001/chrome/browser/ui/brows...
chrome/browser/ui/browser_tabstrip.cc:35: if (show_ntp)
Why is this only applied if |show_ntp| is true? (doesn't that run counter to the
alt+enter test case or other cases with urls, like 'open link in new tab'?) I
wonder if this really is the right fix, and kinda wonder why we don't always
default to this behavior. Can you seek a reviewer with more experience here?