Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810853002: Blink Platform: Erase GraphicsLayerFactory. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Platform: Erase GraphicsLayerFactory. It is useless with new Animation system. BUG=575041 Committed: https://crrev.com/cbdd98ca3f0505261dae07b239031d291739d0c6 Cr-Commit-Position: refs/heads/master@{#381661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -290 lines) Patch
M third_party/WebKit/Source/core/frame/FrameViewTest.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 6 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/GraphicsLayerFactory.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/FakeGraphicsLayerFactory.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/FakeGraphicsLayerFactory.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/web/GraphicsLayerFactoryChromium.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/web/GraphicsLayerFactoryChromium.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
loyso (OOO)
4 years, 9 months ago (2016-03-17 02:51:31 UTC) #3
aelias_OOO_until_Jul13
Source/web lgtm
4 years, 9 months ago (2016-03-17 03:02:31 UTC) #4
esprehn
lgtm
4 years, 9 months ago (2016-03-17 03:42:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810853002/1
4 years, 9 months ago (2016-03-17 04:38:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 04:44:34 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 04:45:23 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbdd98ca3f0505261dae07b239031d291739d0c6
Cr-Commit-Position: refs/heads/master@{#381661}

Powered by Google App Engine
This is Rietveld 408576698