Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1810383004: allow more options for shader blitprocs (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix initializer syntax #

Patch Set 3 : gcc hates my curlies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -60 lines) Patch
M include/core/SkShader.h View 2 chunks +23 lines, -8 lines 0 comments Download
M src/core/SkBlitter_PM4f.cpp View 1 2 8 chunks +20 lines, -25 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +27 lines, -9 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
reed1
4 years, 9 months ago (2016-03-18 18:27:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810383004/1
4 years, 9 months ago (2016-03-18 18:27:48 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/5474) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 9 months ago (2016-03-18 18:28:58 UTC) #7
f(malita)
lgtm
4 years, 9 months ago (2016-03-18 18:51:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810383004/20001
4 years, 9 months ago (2016-03-18 18:53:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/7187)
4 years, 9 months ago (2016-03-18 18:55:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810383004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810383004/40001
4 years, 9 months ago (2016-03-18 19:20:39 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 19:42:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/58fc94e55fb52704f86aa6fde97719131a3c9ed4

Powered by Google App Engine
This is Rietveld 408576698