Fix shelf overflow bubble position

Fix shelf overflow bubble position

BUG=589194
TEST=Put too many icons on shelf, move shelf to left, click chevron to
open overflow bubble.  Observe that bubble doesn't overlap shelf.

Committed: https://crrev.com/52e718a6d988b6058c0823955a8a70298e675c1d
Cr-Commit-Position: refs/heads/master@{#381855}

[Greg Levin, 2016-03-17 17:41:39]

glevin@chromium.org changed reviewers:
+ skuhne@chromium.org

[Greg Levin, 2016-03-17 17:41:40]

Please have a look!

https://codereview.chromium.org/1809963003/diff/1/ash/shelf/overflow_bubble_v...
File ash/shelf/overflow_bubble_view.cc (right):

https://codereview.chromium.org/1809963003/diff/1/ash/shelf/overflow_bubble_v...
ash/shelf/overflow_bubble_view.cc:45: set_arrow(GetBubbleArrow());
GetBubbleArrow() depends on having access to shelf view.  Prior to
https://codereview.chromium.org/1659283002/diff/80001/ash/shelf/overflow_bubb...
SetAnchorView() was sufficient to provide access to shelf view; that change
switched to using shelf_view_ in GetBubbleArrow(), which was still NULL at this
point.  No shelf view -> no arrow -> wrong bubble placement for vertical
shelves.

[Mr4D (OOO till 08-26), 2016-03-17 18:07:17]

Could you please add a unit test to cover this case?

Beside that it looks good to me.

[Greg Levin, 2016-03-17 22:50:22]

On 2016/03/17 18:07:17, Mr4D wrote:
> Could you please add a unit test to cover this case?

Done: New test fails on old code, passes after applying my change.

Please have another look!

[Mr4D (OOO till 08-26), 2016-03-17 23:22:32]

Cool! Many thanks for the great test!

LGTM!

[Greg Levin, 2016-03-18 00:03:45]

The CQ bit was checked by glevin@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809963003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809963003/20001

[commit-bot: I haz the power, 2016-03-18 00:52:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 00:53:37]

Description was changed from

==========
Fix shelf overflow bubble position

BUG=589194
TEST=Put too many icons on shelf, move shelf to left, click chevron to
open overflow bubble.  Observe that bubble doesn't overlap shelf.
==========

to

==========
Fix shelf overflow bubble position

BUG=589194
TEST=Put too many icons on shelf, move shelf to left, click chevron to
open overflow bubble.  Observe that bubble doesn't overlap shelf.

Committed: https://crrev.com/52e718a6d988b6058c0823955a8a70298e675c1d
Cr-Commit-Position: refs/heads/master@{#381855}
==========

[commit-bot: I haz the power, 2016-03-18 00:53:38]

Patchset 2 (id:??) landed as
https://crrev.com/52e718a6d988b6058c0823955a8a70298e675c1d
Cr-Commit-Position: refs/heads/master@{#381855}