Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: ash/shelf/overflow_bubble_view.cc

Issue 1809963003: Fix shelf overflow bubble position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/overflow_bubble_view.cc
diff --git a/ash/shelf/overflow_bubble_view.cc b/ash/shelf/overflow_bubble_view.cc
index ff0f2c38885d5d17ad929e546350a0d7bd98bdd8..6573de0d550549d56bf98073463fa5e534b3a9d8 100644
--- a/ash/shelf/overflow_bubble_view.cc
+++ b/ash/shelf/overflow_bubble_view.cc
@@ -38,6 +38,9 @@ OverflowBubbleView::~OverflowBubbleView() {}
void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
ShelfView* shelf_view) {
+ shelf_view_ = shelf_view;
+ AddChildView(shelf_view_);
+
SetAnchorView(anchor);
set_arrow(GetBubbleArrow());
set_background(NULL);
@@ -52,9 +55,6 @@ void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
layer()->SetFillsBoundsOpaquely(false);
layer()->SetMasksToBounds(true);
- shelf_view_ = shelf_view;
- AddChildView(shelf_view_);
-
set_parent_window(Shell::GetContainer(
anchor->GetWidget()->GetNativeWindow()->GetRootWindow(),
kShellWindowId_ShelfBubbleContainer));
« no previous file with comments | « no previous file | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698