Fix shelf overflow bubble position

ash/shelf/overflow_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/overflow_bubble_view.h"
 
 #include <algorithm>
 
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf.h"
@@ skipping 20 matching lines @@
 const int kShelfViewLeadingInset = 8;
 
 }  // namespace
 
 OverflowBubbleView::OverflowBubbleView() : shelf_view_(NULL) {}
 
 OverflowBubbleView::~OverflowBubbleView() {}
 
 void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
                                             ShelfView* shelf_view) {
+  shelf_view_ = shelf_view;
+  AddChildView(shelf_view_);
+
   SetAnchorView(anchor);
   set_arrow(GetBubbleArrow());

[Greg Levin, 2016/03/17 17:41:39]

GetBubbleArrow() depends on having access to shelf view.  Prior to
https://codereview.chromium.org/1659283002/diff/80001/ash/shelf/overflow_bubb...
SetAnchorView() was sufficient to provide access to shelf view; that change
switched to using shelf_view_ in GetBubbleArrow(), which was still NULL at this
point.  No shelf view -> no arrow -> wrong bubble placement for vertical
shelves.

   set_background(NULL);
   set_color(SkColorSetARGB(kShelfBackgroundAlpha, 0, 0, 0));
   set_margins(gfx::Insets(kPadding, kPadding, kPadding, kPadding));
   // Overflow bubble should not get focus. If it get focus when it is shown,
   // active state item is changed to running state.
   set_can_activate(false);
 
   // Makes bubble view has a layer and clip its children layers.
   SetPaintToLayer(true);
   layer()->SetFillsBoundsOpaquely(false);
   layer()->SetMasksToBounds(true);
 
-  shelf_view_ = shelf_view;
-  AddChildView(shelf_view_);
-
   set_parent_window(Shell::GetContainer(
       anchor->GetWidget()->GetNativeWindow()->GetRootWindow(),
       kShellWindowId_ShelfBubbleContainer));
   views::BubbleDelegateView::CreateBubble(this);
 }
 
 bool OverflowBubbleView::IsHorizontalAlignment() const {
   return shelf_view_ ? shelf_view_->shelf()->IsHorizontalAlignment() : false;
 }
 
@@ skipping 134 matching lines @@
 
     bubble_rect.Offset(0, offset);
     border->set_arrow_offset(anchor_rect.CenterPoint().y() - bubble_rect.y());
   }
 
   GetBubbleFrameView()->SchedulePaint();
   return bubble_rect;
 }
 
 }  // namespace ash