Issue 18098007: Get rid of SVGPoint special case from the bindings generator

Issue 18098007: Get rid of SVGPoint special case from the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
haraken, Stephen Chennney, pdr.

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, leviw+renderwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, Stephen Chennney, Nate Chapin, do-not-use, lgombos, krit

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of SVGPoint special case from the bindings generator Get rid of SVGPoint special case from the bindings generator by adding a new SVGPoint.h header that contains a typedef to FloatPoint. Also use SVGPoint type in the implementation API for consistency with the IDL. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154164

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -56 lines)			Patch
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGRoot.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextQuery.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/svg/SVGTextQuery.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGPathElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGPathElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPathTraversalStateBuilder.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGPathTraversalStateBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGPathUtilities.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGPathUtilities.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/core/svg/SVGPoint.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	Source/core/svg/SVGPointList.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGTextContentElement.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGTextContentElement.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGZoomEvent.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/svg/SVGZoomEvent.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18098007/1

7 years, 5 months ago (2013-07-12 14:38:56 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16524

7 years, 5 months ago (2013-07-12 15:12:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18098007/1

7 years, 5 months ago (2013-07-13 11:39:40 UTC) #5

Message was sent while issue was closed.

Change committed as 154164

Expand Messages | Collapse Messages