Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 18098007: Get rid of SVGPoint special case from the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index d427ea273b9b12641e4d6ab7cb0f7f3ba7b8f337..13dbc97358e412b55403a92bcd8376980db8e647 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -213,7 +213,7 @@ my %svgTypeNeedingTearOff = (
"SVGNumber" => "SVGPropertyTearOff<float>",
"SVGNumberList" => "SVGListPropertyTearOff<SVGNumberList>",
"SVGPathSegList" => "SVGPathSegListPropertyTearOff",
- "SVGPoint" => "SVGPropertyTearOff<FloatPoint>",
+ "SVGPoint" => "SVGPropertyTearOff<SVGPoint>",
"SVGPointList" => "SVGListPropertyTearOff<SVGPointList>",
"SVGPreserveAspectRatio" => "SVGPropertyTearOff<SVGPreserveAspectRatio>",
"SVGRect" => "SVGPropertyTearOff<FloatRect>",
@@ -419,8 +419,8 @@ sub SkipIncludeHeader
return 1 if IsCallbackFunctionType($type);
return 1 if $type eq "DOMString";
- # Special case: SVGPoint.h / SVGNumber.h do not exist.
- return 1 if $type eq "SVGPoint" or $type eq "SVGNumber";
+ # Special case: SVGNumber.h does not exist.
+ return 1 if $type eq "SVGNumber";
return 0;
}
@@ -527,10 +527,6 @@ sub GetSVGPropertyTypes
AddToHeaderIncludes("core/svg/properties/SVGPathSegListPropertyTearOff.h");
}
- if ($svgPropertyType) {
- $svgPropertyType = "SVGPoint" if $svgPropertyType eq "FloatPoint";
- }
-
return ($svgPropertyType, $svgListPropertyType, $svgNativeType);
}
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698