samplecode/SampleApp.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleApp.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleApp.cpp

diff --git a/samplecode/SampleApp.cpp b/samplecode/SampleApp.cpp

index 6d5f647b158cee1df0baa5f8138a1afba6845474..72122234d9151d1d207f34d6a388467b163202b5 100644

--- a/samplecode/SampleApp.cpp

+++ b/samplecode/SampleApp.cpp

@@ -261,7 +261,7 @@ public:

fCurIntf = nullptr;

SkDebugf("Failed to setup 3D");

- win->detach();

+ win->release();

}

#endif // SK_SUPPORT_GPU

// call windowSizeChanged to create the render target

@@ -283,7 +283,7 @@ public:

SkSafeUnref(fCurRenderTarget);

fCurRenderTarget = nullptr;

#endif

- win->detach();

+ win->release();

fBackend = kNone_BackEndType;

}