blink: Remove unused or rarely used methods from WebGraphicsContext3D

blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/5260676ed275358c7b44da823b97bc1084c7a25e
Cr-Commit-Position: refs/heads/master@{#381586}

[danakj, 2016-03-15 23:54:23]

Description was changed from

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr@chromium.org,esprehn@chromium.org
BUG=584497
==========

to

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr@chromium.org,esprehn@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-15 23:54:55]

Description was changed from

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr@chromium.org,esprehn@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr@chromium.org,esprehn@chromium.org,sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-15 23:54:56]

danakj@chromium.org changed reviewers:
+ sievers@chromium.org

[danakj, 2016-03-15 23:55:33]

Description was changed from

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr@chromium.org,esprehn@chromium.org,sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-15 23:55:34]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org

[danakj, 2016-03-15 23:56:49]

kbr: content/ WebKit/modules/ WebKit/platform/
esprehn or chrishtr: WebKit/public/ and WebKit/core/testing/
sievers: gpu/blink/

[danakj, 2016-03-15 23:56:54]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 23:57:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809553002/1

[commit-bot: I haz the power, 2016-03-16 00:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[chrishtr, 2016-03-16 00:09:30]

lgtm

[commit-bot: I haz the power, 2016-03-16 00:09:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Russell (switch to Gerrit), 2016-03-16 00:18:22]

Thank you for working on this cleanup and removal! LGTM already.

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebGraphicsContext3D.h (left):

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebGraphicsContext3D.h:145: virtual void
reshapeWithScaleFactor(int width, int height, float scaleFactor) { }
I think some test code will need to be deleted to handle the removal of this
method.

[danakj, 2016-03-16 00:19:28]

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebGraphicsContext3D.h (left):

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebGraphicsContext3D.h:145: virtual void
reshapeWithScaleFactor(int width, int height, float scaleFactor) { }
On 2016/03/16 00:18:22, Ken Russell wrote:
> I think some test code will need to be deleted to handle the removal of this
> method.

I can find no calls to it with grep (outside of cc tests which are unrelated).
Where are you thinking?

[esprehn, 2016-03-16 00:26:10]

lgtm

[no sievers, 2016-03-16 00:26:16]

On 2016/03/16 00:19:28, danakj wrote:
>
https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/WebGraphicsContext3D.h (left):
> 
>
https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebGraphicsContext3D.h:145: virtual void
> reshapeWithScaleFactor(int width, int height, float scaleFactor) { }
> On 2016/03/16 00:18:22, Ken Russell wrote:
> > I think some test code will need to be deleted to handle the removal of this
> > method.
> 
> I can find no calls to it with grep (outside of cc tests which are unrelated).
> Where are you thinking?

lgtm since you are removing all the respective non-pure-virtual dummy functions
too.

[Ken Russell (switch to Gerrit), 2016-03-16 00:29:55]

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebGraphicsContext3D.h (left):

https://codereview.chromium.org/1809553002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebGraphicsContext3D.h:145: virtual void
reshapeWithScaleFactor(int width, int height, float scaleFactor) { }
On 2016/03/16 00:19:28, danakj wrote:
> On 2016/03/16 00:18:22, Ken Russell wrote:
> > I think some test code will need to be deleted to handle the removal of this
> > method.
> 
> I can find no calls to it with grep (outside of cc tests which are unrelated).
> Where are you thinking?

Yes, it was the cc/ tests I found via codesearch. I see your point about the
containing class being unrelated. Never mind.

[danakj, 2016-03-16 02:01:14]

Patchset #4 (id:60001) has been deleted

[danakj, 2016-03-16 17:48:53]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-16 17:48:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, kbr@chromium.org, esprehn@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1809553002/#ps80001
(title: "wgc3d-unused: depends?")

[commit-bot: I haz the power, 2016-03-16 17:49:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809553002/80001

[commit-bot: I haz the power, 2016-03-16 18:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 18:10:41]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[danakj, 2016-03-16 18:42:03]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-16 18:42:03]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org, esprehn@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1809553002/#ps100001
(title: "wgc3d-unused: .")

[commit-bot: I haz the power, 2016-03-16 18:42:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809553002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809553002/100001

[commit-bot: I haz the power, 2016-03-16 18:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 18:57:10]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[danakj, 2016-03-16 19:48:47]

WebMediaPlayerAndroid::copyVideoTextureToPlatformTexture also takes a WGC3D.
Made it grab the GLES2Interface off it and use that mostly, but kept using the
WGC3D for flush() for now, just in case it matters to the lastFlushId().

[danakj, 2016-03-16 19:52:15]

Patchset #6 (id:120001) has been deleted

[danakj, 2016-03-16 19:52:29]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-16 19:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org, esprehn@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1809553002/#ps140001
(title: "wgc3d-unused:
WebMediaPlayerAndroid::copyVideoTextureToPlatformTexture")

[commit-bot: I haz the power, 2016-03-16 19:52:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809553002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809553002/140001

[commit-bot: I haz the power, 2016-03-16 21:55:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:55:24]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[danakj, 2016-03-16 21:57:28]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:57:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809553002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809553002/140001

[commit-bot: I haz the power, 2016-03-16 23:28:05]

Description was changed from

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-16 23:28:07]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-03-16 23:29:30]

Description was changed from

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
blink: Remove unused or rarely used methods from WebGraphicsContext3D

This is toward deleting the class entirely. These methods were not used
at all, or for a couple of them, had one caller which we redirect to the
GLES2Interface directly.

Adds a DEPS entry for core/testing/ to use GLES2Interface as there's
code in there calling things on WebGraphicsContext3D now.

R=kbr,esprehn,sievers,chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/5260676ed275358c7b44da823b97bc1084c7a25e
Cr-Commit-Position: refs/heads/master@{#381586}
==========

[commit-bot: I haz the power, 2016-03-16 23:29:31]

Patchset 6 (id:??) landed as
https://crrev.com/5260676ed275358c7b44da823b97bc1084c7a25e
Cr-Commit-Position: refs/heads/master@{#381586}