android: Hide the WebGraphicsContext3D in GLHelperHolder

android: Hide the WebGraphicsContext3D in GLHelperHolder

The GLHelperHolder in RenderWidgetHostViewAndroid wants to use a
command-buffer-aware context, which means it has to create a
WebGraphicsContext3DImpl. However we can hide that behind the
ContextProviderCommandBuffer API, to help us deprecate and
delete the WebGraphicsContext3D class.

We make a few cleanups to the class overall while we're touching it.

R=sievers@chromium.org
BUG=584497
Committed: https://crrev.com/8cf168c5eb0ae5fb5480dfb32fb623873e6cbd8a
Cr-Commit-Position: refs/heads/master@{#381639}

[danakj, 2016-03-16 20:17:05]

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:181:
BROWSER_OFFSCREEN_MAINTHREAD_CONTEXT);
Is this the right context type?

[danakj, 2016-03-16 23:09:14]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 23:09:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805343005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805343005/1

[commit-bot: I haz the power, 2016-03-16 23:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 23:22:47]

Dry run: This issue passed the CQ dry run.

[no sievers, 2016-03-16 23:27:10]

lgtm

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:181:
BROWSER_OFFSCREEN_MAINTHREAD_CONTEXT);
On 2016/03/16 20:17:05, danakj wrote:
> Is this the right context type?

yes that's good, and you can remove the SetContextType() call in the line above
now.

[danakj, 2016-03-16 23:29:13]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-16 23:29:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1805343005/#ps20001
(title: "wgc3d-rwhva: removedsetcontext")

[danakj, 2016-03-16 23:29:16]

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1805343005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:181:
BROWSER_OFFSCREEN_MAINTHREAD_CONTEXT);
On 2016/03/16 23:27:10, sievers (slow) wrote:
> On 2016/03/16 20:17:05, danakj wrote:
> > Is this the right context type?
> 
> yes that's good, and you can remove the SetContextType() call in the line
above
> now.

Done.

[commit-bot: I haz the power, 2016-03-16 23:29:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805343005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805343005/20001

[commit-bot: I haz the power, 2016-03-17 02:00:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 02:01:29]

Description was changed from

==========
android: Hide the WebGraphicsContext3D in GLHelperHolder

The GLHelperHolder in RenderWidgetHostViewAndroid wants to use a
command-buffer-aware context, which means it has to create a
WebGraphicsContext3DImpl. However we can hide that behind the
ContextProviderCommandBuffer API, to help us deprecate and
delete the WebGraphicsContext3D class.

We make a few cleanups to the class overall while we're touching it.

R=sievers@chromium.org
BUG=584497
==========

to

==========
android: Hide the WebGraphicsContext3D in GLHelperHolder

The GLHelperHolder in RenderWidgetHostViewAndroid wants to use a
command-buffer-aware context, which means it has to create a
WebGraphicsContext3DImpl. However we can hide that behind the
ContextProviderCommandBuffer API, to help us deprecate and
delete the WebGraphicsContext3D class.

We make a few cleanups to the class overall while we're touching it.

R=sievers@chromium.org
BUG=584497

Committed: https://crrev.com/8cf168c5eb0ae5fb5480dfb32fb623873e6cbd8a
Cr-Commit-Position: refs/heads/master@{#381639}
==========

[commit-bot: I haz the power, 2016-03-17 02:01:30]

Patchset 2 (id:??) landed as
https://crrev.com/8cf168c5eb0ae5fb5480dfb32fb623873e6cbd8a
Cr-Commit-Position: refs/heads/master@{#381639}