[css-grid] Fix wrong type in GridPositionsResolver method

[css-grid] Fix wrong type in GridPositionsResolver method

We were using size_t instead of int in
definiteGridSpanWithSpanAgainstOpposite() for oppositeLine.
oppositeLine could be negative and that would be right.

Current code is working fine as the result is used as an int later.

No new tests, no change of behavior.

Committed: https://crrev.com/a97669f29540876fce2b0cc0be546973ecd28dbd
Cr-Commit-Position: refs/heads/master@{#381947}

[Manuel Rego, 2016-03-17 15:58:49]

rego@igalia.com changed reviewers:
+ rune@opera.com, svillar@igalia.com, timloh@chromium.org

[Manuel Rego, 2016-03-17 15:58:50]

Very simple patch.

[rune, 2016-03-17 18:30:16]

https://codereview.chromium.org/1809143002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):

https://codereview.chromium.org/1809143002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:153: static
GridSpan definiteGridSpanWithSpanAgainstOpposite(int opossiteLine, const
GridPosition& position, GridPositionSide side)
oppositeLine ?

[svillar, 2016-03-18 09:24:33]

I guess it could cause problems on architectures where sizeof(size_t) !=
sizeof(int).

lgtm with the typo fix spotted by rune.

[Manuel Rego, 2016-03-18 09:40:02]

Thanks for the reviews.

https://codereview.chromium.org/1809143002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):

https://codereview.chromium.org/1809143002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:153: static
GridSpan definiteGridSpanWithSpanAgainstOpposite(int opossiteLine, const
GridPosition& position, GridPositionSide side)
On 2016/03/17 18:30:16, rune wrote:
> oppositeLine ?

Yeah, sure the typo should be fixed actually in:
https://codereview.chromium.org/1808193002/

Which is the one adding "opossiteLine" all over the place.
Sorry about that.

[rune, 2016-03-18 09:56:57]

lgtm

[Manuel Rego, 2016-03-18 11:18:34]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-03-18 11:18:35]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/1809143002/#ps20001
(title: "Rebased version after fixing typo in previous patch")

[commit-bot: I haz the power, 2016-03-18 11:18:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809143002/20001

[commit-bot: I haz the power, 2016-03-18 13:15:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 13:16:40]

Description was changed from

==========
[css-grid] Fix wrong type in GridPositionsResolver method

We were using size_t instead of int in
definiteGridSpanWithSpanAgainstOpposite() for oppositeLine.
oppositeLine could be negative and that would be right.

Current code is working fine as the result is used as an int later.

No new tests, no change of behavior.
==========

to

==========
[css-grid] Fix wrong type in GridPositionsResolver method

We were using size_t instead of int in
definiteGridSpanWithSpanAgainstOpposite() for oppositeLine.
oppositeLine could be negative and that would be right.

Current code is working fine as the result is used as an int later.

No new tests, no change of behavior.

Committed: https://crrev.com/a97669f29540876fce2b0cc0be546973ecd28dbd
Cr-Commit-Position: refs/heads/master@{#381947}
==========

[commit-bot: I haz the power, 2016-03-18 13:16:41]

Patchset 2 (id:??) landed as
https://crrev.com/a97669f29540876fce2b0cc0be546973ecd28dbd
Cr-Commit-Position: refs/heads/master@{#381947}