third_party/WebKit/Source/core/style/GridPositionsResolver.cpp - Issue 1809143002: [css-grid] Fix wrong type in GridPositionsResolver method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

Issue 1809143002: [css-grid] Fix wrong type in GridPositionsResolver method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grid-span-last-rename

Patch Set: Rebased version after fixing typo in previous patch Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

diff --git a/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp b/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

index 8acd059a5f7bed48a488ada2a08f4e2bff12dd97..8a6b566a19e4fdb330233c34be93878043b83c62 100644

--- a/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

+++ b/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp

@@ -150,7 +150,7 @@ static GridSpan resolveNamedGridLinePositionAgainstOppositePosition(const Comput

return definiteGridSpanWithNamedSpanAgainstOpposite(oppositeLine, position, side, gridLines, lastLine);

}

-static GridSpan definiteGridSpanWithSpanAgainstOpposite(size_t oppositeLine, const GridPosition& position, GridPositionSide side)

+static GridSpan definiteGridSpanWithSpanAgainstOpposite(int oppositeLine, const GridPosition& position, GridPositionSide side)

{

size_t positionOffset = position.spanPosition();

if (side == ColumnStartSide || side == RowStartSide)

« no previous file with comments | « no previous file | no next file » | no next file with comments »