Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 1808193002: [css-grid] Rename GridSpan properties (Closed)

Created:
3 years ago by Manuel Rego
Modified:
3 years ago
Reviewers:
svillar, Timothy Loh, rune
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-css, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, eae+blinkwatch, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Rename GridSpan properties GridSpan was using old names initialResolvedPosition and finalResolvedPosition. This patch rename them to startLine and endLine. Some reasons for this refactoring: * "position" is a vague term not defined in the spec. * GridSpan is currently storing grid lines. A grid "line" is defined in the spec: https://drafts.csswg.org/css-grid/#grid-line-concept * The spec uses the concepts "start" and "end" lines too. No new tests, no change of behavior. BUG=444011 Committed: https://crrev.com/f1f4acccc0a6f34ae712788f7b18c61876644463 Cr-Commit-Position: refs/heads/master@{#381930}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Fix typo opossiteLine vs oppositeLine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -104 lines) Patch
M third_party/WebKit/Source/core/css/CSSGridTemplateAreasValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 18 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridArea.h View 1 4 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridPositionsResolver.cpp View 1 2 5 chunks +26 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Manuel Rego
3 years ago (2016-03-17 13:00:18 UTC) #2
svillar
Shorter and more correct names, no-brainer lgtm https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/core/style/GridArea.h File third_party/WebKit/Source/core/style/GridArea.h (right): https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/core/style/GridArea.h#newcode48 third_party/WebKit/Source/core/style/GridArea.h:48: // Iterating ...
3 years ago (2016-03-17 13:21:51 UTC) #3
Manuel Rego
Thanks for the quick review. Now I need an OWNER of style/. @timloh and/or @rune, ...
3 years ago (2016-03-17 15:02:06 UTC) #4
Timothy Loh
stamp lgtm
3 years ago (2016-03-17 23:15:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808193002/20001
3 years ago (2016-03-18 08:01:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808193002/40001
3 years ago (2016-03-18 09:43:25 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years ago (2016-03-18 10:58:07 UTC) #13
commit-bot: I haz the power
3 years ago (2016-03-18 10:59:18 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1f4acccc0a6f34ae712788f7b18c61876644463
Cr-Commit-Position: refs/heads/master@{#381930}

Powered by Google App Engine
This is Rietveld 408576698