[css-grid] Rename GridSpan properties

[css-grid] Rename GridSpan properties

GridSpan was using old names initialResolvedPosition and
finalResolvedPosition.
This patch rename them to startLine and endLine.

Some reasons for this refactoring:
* "position" is a vague term not defined in the spec.
* GridSpan is currently storing grid lines. A grid "line" is defined
  in the spec: https://drafts.csswg.org/css-grid/#grid-line-concept
* The spec uses the concepts "start" and "end" lines too.

No new tests, no change of behavior.

BUG=444011
Committed: https://crrev.com/f1f4acccc0a6f34ae712788f7b18c61876644463
Cr-Commit-Position: refs/heads/master@{#381930}

[Manuel Rego, 2016-03-17 13:00:17]

rego@igalia.com changed reviewers:
+ rune@opera.com, svillar@igalia.com, timloh@chromium.org

[svillar, 2016-03-17 13:21:51]

Shorter and more correct names, no-brainer lgtm

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridArea.h (right):

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridArea.h:48: // Iterating over the span
shouldn't include |endLine| to be correct.
Perhaps we should remove this last sentence. It isn't easy to understand why is
not correct.

Also perhaps we should clarify that although the first line in a grid is line
#1, that is internally stored as 0.

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:153: static
GridSpan definiteGridSpanWithSpanAgainstOpposite(size_t opossiteLine, const
GridPosition& position, GridPositionSide side)
Not directly related with the patch but why are we using size_t here? Couldn't
it be a negative line number?

[Manuel Rego, 2016-03-17 15:02:06]

Thanks for the quick review.

Now I need an OWNER of style/.
@timloh and/or @rune, could you please take a look?

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridArea.h (right):

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridArea.h:48: // Iterating over the span
shouldn't include |endLine| to be correct.
On 2016/03/17 13:21:51, svillar wrote:
> Perhaps we should remove this last sentence. It isn't easy to understand why
is
> not correct.
> 
> Also perhaps we should clarify that although the first line in a grid is line
> #1, that is internally stored as 0.

Done.

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridPositionsResolver.cpp (right):

https://codereview.chromium.org/1808193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridPositionsResolver.cpp:153: static
GridSpan definiteGridSpanWithSpanAgainstOpposite(size_t opossiteLine, const
GridPosition& position, GridPositionSide side)
On 2016/03/17 13:21:51, svillar wrote:
> Not directly related with the patch but why are we using size_t here? Couldn't
> it be a negative line number?

Yep, you're right, this is wrong.
It's working fine just by chance because later it's used as an int.

I'll fix it in a different patch.

[Timothy Loh, 2016-03-17 23:15:46]

stamp lgtm

[Manuel Rego, 2016-03-18 08:00:55]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-03-18 08:00:56]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com
Link to the patchset: https://codereview.chromium.org/1808193002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-18 08:01:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808193002/20001

[Manuel Rego, 2016-03-18 09:38:47]

The CQ bit was unchecked by rego@igalia.com

[Manuel Rego, 2016-03-18 09:43:13]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-03-18 09:43:14]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com,
timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1808193002/#ps40001
(title: "Fix typo opossiteLine vs oppositeLine")

[commit-bot: I haz the power, 2016-03-18 09:43:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808193002/40001

[commit-bot: I haz the power, 2016-03-18 10:58:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 10:59:17]

Description was changed from

==========
[css-grid] Rename GridSpan properties

GridSpan was using old names initialResolvedPosition and
finalResolvedPosition.
This patch rename them to startLine and endLine.

Some reasons for this refactoring:
* "position" is a vague term not defined in the spec.
* GridSpan is currently storing grid lines. A grid "line" is defined
  in the spec: https://drafts.csswg.org/css-grid/#grid-line-concept
* The spec uses the concepts "start" and "end" lines too.

No new tests, no change of behavior.

BUG=444011
==========

to

==========
[css-grid] Rename GridSpan properties

GridSpan was using old names initialResolvedPosition and
finalResolvedPosition.
This patch rename them to startLine and endLine.

Some reasons for this refactoring:
* "position" is a vague term not defined in the spec.
* GridSpan is currently storing grid lines. A grid "line" is defined
  in the spec: https://drafts.csswg.org/css-grid/#grid-line-concept
* The spec uses the concepts "start" and "end" lines too.

No new tests, no change of behavior.

BUG=444011

Committed: https://crrev.com/f1f4acccc0a6f34ae712788f7b18c61876644463
Cr-Commit-Position: refs/heads/master@{#381930}
==========

[commit-bot: I haz the power, 2016-03-18 10:59:18]

Patchset 3 (id:??) landed as
https://crrev.com/f1f4acccc0a6f34ae712788f7b18c61876644463
Cr-Commit-Position: refs/heads/master@{#381930}