Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1808833002: Revert of Add SkSpecialImage::extractSubset & NewFromPixmap (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkSpecialImage::extractSubset & NewFromPixmap (patchset #5 id:80001 of https://codereview.chromium.org/1787883002/ ) Reason for revert: Need to wean ImagePixelLocker.h off of SkAutoPixmapStorage :( Original issue's description: > Add SkSpecialImage::extractSubset & NewFromPixmap > > This is calved off of: https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1787883002 > > Committed: https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002 TBR=bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/19dea94f1d073c20dfd26d36a7f86e0bc57f04e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -346 lines) Patch
M bench/CoverageBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M bench/PDFBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/image.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPixmap.h View 1 chunk +65 lines, -0 lines 0 comments Download
D src/core/SkAutoPixmapStorage.h View 1 chunk +0 lines, -87 lines 0 comments Download
D src/core/SkAutoPixmapStorage.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M src/core/SkPixmap.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkSpecialImage.h View 3 chunks +13 lines, -26 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 13 chunks +17 lines, -70 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DeviceLooperTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/Float16Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 6 chunks +13 lines, -86 lines 0 comments Download
M tests/TestingSpecialImageAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/TextureCompressionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Add SkSpecialImage::extractSubset & NewFromPixmap
4 years, 9 months ago (2016-03-16 17:38:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808833002/1
4 years, 9 months ago (2016-03-16 17:39:01 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:39:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19dea94f1d073c20dfd26d36a7f86e0bc57f04e0

Powered by Google App Engine
This is Rietveld 408576698