Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1808533003: Revert of Reduce ActiveDOMObjects from core/ (Closed)

Created:
4 years, 9 months ago by dewittj
Modified:
4 years, 9 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, shans, tzik, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-worker-reviews_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, sof, nhiroki, darktears, michaeln, blink-reviews-animation_chromium.org, serviceworker-reviews, falken, blink-reviews-events_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reduce ActiveDOMObjects from core/ (patchset #4 id:60001 of https://codereview.chromium.org/1750453002/ ) Reason for revert: Revert requested by Ligi Vinod and amineer Original issue's description: > Reduce ActiveDOMObjects from core/ > > Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion, > this CL replaces a bunch of ActiveDOMObjects in core/ with ContextLifecycleObservers. > > No change in behavior. > > BUG=589507 > > Committed: https://crrev.com/fe7d013fb54ea6a85751043d439930fa85b0c51b > Cr-Commit-Position: refs/heads/master@{#378191} TBR=sigbjornf@opera.com,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589507, 591982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -81 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 4 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryListTest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.h View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.h View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReader.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.h View 3 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.cpp View 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dewittj
Created Revert of Reduce ActiveDOMObjects from core/
4 years, 9 months ago (2016-03-15 23:26:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808533003/1
4 years, 9 months ago (2016-03-15 23:27:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808533003/1
4 years, 9 months ago (2016-03-15 23:30:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/173081) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-15 23:33:51 UTC) #8
haraken
4 years, 9 months ago (2016-03-16 07:06:35 UTC) #9
LGTM, but we need to resolve merge conflicts manually.

Powered by Google App Engine
This is Rietveld 408576698