third_party/WebKit/Source/core/dom/MessagePort.cpp - Issue 1808533003: Revert of Reduce ActiveDOMObjects from core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/MessagePort.cpp

Issue 1808533003: Revert of Reduce ActiveDOMObjects from core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/MessagePort.cpp

diff --git a/third_party/WebKit/Source/core/dom/MessagePort.cpp b/third_party/WebKit/Source/core/dom/MessagePort.cpp

index 4c57d77312993f2a3d103b8fd08eae3ce3d89b26..82fceb6323bcb4e60f579de0bd8237c96e17745e 100644

--- a/third_party/WebKit/Source/core/dom/MessagePort.cpp

+++ b/third_party/WebKit/Source/core/dom/MessagePort.cpp

@@ -45,11 +45,13 @@

MessagePort* MessagePort::create(ExecutionContext& executionContext)

{

- return new MessagePort(executionContext);

+ MessagePort* port = new MessagePort(executionContext);

+ port->suspendIfNeeded();

+ return port;

}

MessagePort::MessagePort(ExecutionContext& executionContext)

- : ContextLifecycleObserver(&executionContext)

+ : ActiveDOMObject(&executionContext)

, m_started(false)

, m_closed(false)

, m_weakFactory(this)

@@ -276,7 +278,7 @@

DEFINE_TRACE(MessagePort)

{

- ContextLifecycleObserver::trace(visitor);

+ ActiveDOMObject::trace(visitor);

RefCountedGarbageCollectedEventTargetWithInlineData<MessagePort>::trace(visitor);

}