Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: third_party/WebKit/Source/core/dom/MessagePort.h

Issue 1808533003: Revert of Reduce ActiveDOMObjects from core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/MessagePort.h
diff --git a/third_party/WebKit/Source/core/dom/MessagePort.h b/third_party/WebKit/Source/core/dom/MessagePort.h
index 556ceeeeb038ab691aacdfbf9d07fc4b4d53c025..8e7f8083906dc0fa05df0154fd486a15df2d17c6 100644
--- a/third_party/WebKit/Source/core/dom/MessagePort.h
+++ b/third_party/WebKit/Source/core/dom/MessagePort.h
@@ -28,7 +28,7 @@
#define MessagePort_h
#include "core/CoreExport.h"
-#include "core/dom/ContextLifecycleObserver.h"
+#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventListener.h"
#include "core/events/EventTarget.h"
#include "public/platform/WebMessagePortChannel.h"
@@ -57,7 +57,7 @@
class CORE_EXPORT MessagePort
: public RefCountedGarbageCollectedEventTargetWithInlineData<MessagePort>
- , public ContextLifecycleObserver
+ , public ActiveDOMObject
, public WebMessagePortChannelClient {
DEFINE_WRAPPERTYPEINFO();
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MessagePort);
@@ -86,11 +86,12 @@
bool started() const { return m_started; }
const AtomicString& interfaceName() const override;
- ExecutionContext* executionContext() const override { return ContextLifecycleObserver::executionContext(); }
+ ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
MessagePort* toMessagePort() override { return this; }
+ // ActiveDOMObject implementation.
bool hasPendingActivity() const override;
- void contextDestroyed() override { close(); }
+ void stop() override { close(); }
void setOnmessage(PassRefPtrWillBeRawPtr<EventListener> listener)
{

Powered by Google App Engine
This is Rietveld 408576698