Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1808083002: Migrate ExtensionPopup from BubbleDelegateView to (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
tapted, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate ExtensionPopup from BubbleDelegateView to BubbleDialogDelegateView In this particular case there's no behavior change and no huge win, except that it will allow us to one day remove BubbleDelegateView completely (or greatly trim it down). BUG=591583 Committed: https://crrev.com/7d6d85cc55de671a7585ecb356e2d1121d046a8b Cr-Commit-Position: refs/heads/master@{#382042}

Patch Set 1 #

Patch Set 2 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Evan Stade
4 years, 9 months ago (2016-03-17 02:01:12 UTC) #3
tapted
lgtm And thanks for updating the not-aura path! I did a spot check - seems ...
4 years, 9 months ago (2016-03-17 02:29:18 UTC) #4
sky
LGTM
4 years, 9 months ago (2016-03-17 13:19:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808083002/1
4 years, 9 months ago (2016-03-17 21:00:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/108629)
4 years, 9 months ago (2016-03-17 21:28:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808083002/20001
4 years, 9 months ago (2016-03-18 18:25:35 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 19:17:01 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 19:18:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d6d85cc55de671a7585ecb356e2d1121d046a8b
Cr-Commit-Position: refs/heads/master@{#382042}

Powered by Google App Engine
This is Rietveld 408576698