Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 1808083002: Migrate ExtensionPopup from BubbleDelegateView to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 37ef720fab4b997ed072e18466c35078978cdd43..3af6bb889e6372e62b22cfa5a12f534176c0f109 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -48,7 +48,7 @@ ExtensionPopup* ExtensionPopup::Create(extensions::ExtensionViewHost* host,
views::BubbleBorder::Arrow arrow,
ShowAction show_action) {
auto popup = new ExtensionPopup(host, anchor_view, arrow, show_action);
- views::BubbleDelegateView::CreateBubble(popup);
+ views::BubbleDialogDelegateView::CreateBubble(popup);
return popup;
}
#endif
@@ -57,7 +57,7 @@ ExtensionPopup::ExtensionPopup(extensions::ExtensionViewHost* host,
views::View* anchor_view,
views::BubbleBorder::Arrow arrow,
ShowAction show_action)
- : BubbleDelegateView(anchor_view, arrow),
+ : BubbleDialogDelegateView(anchor_view, arrow),
host_(host),
devtools_callback_(base::Bind(
&ExtensionPopup::OnDevToolsStateChanged, base::Unretained(this))),
@@ -70,7 +70,6 @@ ExtensionPopup::ExtensionPopup(extensions::ExtensionViewHost* host,
// ExtensionPopup closes itself on very specific de-activation conditions.
set_close_on_deactivate(false);
-
// Listen for the containing view calling window.close();
registrar_.Add(
this,
@@ -100,6 +99,10 @@ ExtensionPopup::~ExtensionPopup() {
host_.get())->GetBrowser()->tab_strip_model()->RemoveObserver(this);
}
+int ExtensionPopup::GetDialogButtons() const {
+ return ui::DIALOG_BUTTON_NONE;
+}
+
void ExtensionPopup::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup.h ('k') | chrome/browser/ui/views/extensions/extension_popup_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698